Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add API for processing groups of plugin-defined DataSource groups #210

Merged
merged 24 commits into from
Oct 4, 2022
Merged

Add API for processing groups of plugin-defined DataSource groups #210

merged 24 commits into from
Oct 4, 2022

Conversation

mslukebo
Copy link
Contributor

@mslukebo mslukebo commented Sep 19, 2022 •
edited
Loading

Closes #213

Adds the interface described in #214, but does not implement using it during Engine processing.

@mslukebo mslukebo marked this pull request as ready for review October 3, 2022 20:41
@mslukebo mslukebo requested a review from helenkzhang October 3, 2022 21:08
@mslukebo mslukebo requested a review from anramanath October 4, 2022 15:47
anramanath
anramanath previously approved these changes Oct 4, 2022
View reviewed changes
anramanath
anramanath previously approved these changes Oct 4, 2022
View reviewed changes
@jmaxson-ms
Copy link
Contributor 

///     <see cref="IDataSource"/>s that can be processed by the

nit:IDataSourceGroup

Refers to: src/Microsoft.Performance.SDK.Runtime/DataSessionSource.cs:15 in e85f28a. [](commit_id = e85f28a, deletion_comment = False)

@anramanath anramanath self-requested a review October 4, 2022 20:43
@mslukebo mslukebo merged commit 6534873 into main Oct 4, 2022
@mslukebo mslukebo deleted the feature/grouping branch October 4, 2022 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anramanath anramanath anramanath approved these changes

@jmaxson-ms jmaxson-ms jmaxson-ms approved these changes

@trgibeau trgibeau Awaiting requested review from trgibeau trgibeau is a code owner

@yesiam0 yesiam0 Awaiting requested review from yesiam0

@helenkzhang helenkzhang Awaiting requested review from helenkzhang helenkzhang is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow plugins to specify which data source combinations can be processed together
3 participants
@mslukebo @jmaxson-ms @anramanath