ProcessedEventData: delay allocation until first event. #342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmaxson-ms
requested review from
anramanath,
mslukebo,
trgibeau and
helenkzhang
as code owners
mslukebo
approved these changes
Feb 21, 2024
helenkzhang
approved these changes
Feb 21, 2024
jmaxson-ms
deleted the
user/jmaxson/processedEventDataAllocationDelay
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a data cooker is using this class and never processes any events from the trace, then performing an initial allocation is a waste of memory.
This change delays that initial allocation until the first event is received.
I tested with an existing XPerf cooker (EtwSessionInfo) to be sure that it works as expected.
This change is important because the more data cookers use this class, the higher the initial allocation cost would become.