Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ContentDialog] Add missing visibility setter for V2 style #5736

Merged
merged 4 commits into from
Nov 11, 2021

Conversation

marcelwgn
Copy link
Collaborator

Description

Adds a missing Visibility setter that would make ContentDIalog take up space in layouts even when not opened.

Motivation and Context

Closes #5713

How Has This Been Tested?

Tested manually

Screenshots (if appropriate):

@ghost ghost added the needs-triage Issue needs to be triaged by the area owners label Aug 20, 2021
@StephenLPeters
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@StephenLPeters StephenLPeters added area-Dialogs team-Controls Issue for the Controls team and removed needs-triage Issue needs to be triaged by the area owners labels Sep 1, 2021
@StephenLPeters
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@karkarl
Copy link
Contributor

karkarl commented Nov 8, 2021

@chingucoding Can you update the visual verification files?

@marcelwgn
Copy link
Collaborator Author

Unfortunately, the last build has already been deleted. Manually trying to figure out the difference was too difficult. Could we rerun the test run?

@karkarl
Copy link
Contributor

karkarl commented Nov 10, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@karkarl
Copy link
Contributor

karkarl commented Nov 11, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@karkarl karkarl merged commit a5050d3 into microsoft:main Nov 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-Dialogs team-Controls Issue for the Controls team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ContentDialog occupies space in a StackPanel
3 participants