-
Notifications
You must be signed in to change notification settings - Fork 698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ContentDialog] Add missing visibility setter for V2 style #5736
Merged
karkarl
merged 4 commits into
microsoft:main
from
marcelwgn:dev/contentdialog-space-takeup
Nov 11, 2021
Merged
[ContentDialog] Add missing visibility setter for V2 style #5736
karkarl
merged 4 commits into
microsoft:main
from
marcelwgn:dev/contentdialog-space-takeup
Nov 11, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
StephenLPeters
added
area-Dialogs
team-Controls
Issue for the Controls team
and removed
needs-triage
Issue needs to be triaged by the area owners
labels
Sep 1, 2021
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
@chingucoding Can you update the visual verification files? |
Unfortunately, the last build has already been deleted. Manually trying to figure out the difference was too difficult. Could we rerun the test run? |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
karkarl
approved these changes
Nov 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a missing Visibility setter that would make ContentDIalog take up space in layouts even when not opened.
Motivation and Context
Closes #5713
How Has This Been Tested?
Tested manually
Screenshots (if appropriate):