Avoid heap corruption issue by setting the property via the DP instead of the property setter #5781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d of the property setter.
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/AZP RUN |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
StephenLPeters
added
area-Materials
asklar
approved these changes
Sep 8, 2021
| @@ -63,6 +64,7 @@ class SharedHelpers | |||
|
|
|||
| // Actual OS version checks | |||
| static bool IsAPIContractV14Available(); // 21H1 | |||
| static bool IsAPIContractV10Available(); // 20H1 | |||
There was a problem hiding this comment.
Suggested change
| static bool IsAPIContractV10Available(); // 20H1 | |
| static bool IsAPIContractV10Available(); // 20H1 |
| { | ||
| // On 19h1 and 19h2 there is a heap corruption bug that occurs when setting the TintLuminosityOpacity via the property, | ||
| // So we'll set it by the DP instead. | ||
| brush.SetValue(winrt::Windows::UI::Xaml::Media::AcrylicBrush::TintLuminosityOpacityProperty(), box_value(luminosityValue)); |
There was a problem hiding this comment.
IIRC the only difference is that this doesn't trigger the "notify on property change" handlers, which is probably ok for this prop but would be worth adding a comment for
miniksa
approved these changes
Sep 9, 2021
StephenLPeters
added a commit
that referenced
this pull request
Dec 2, 2021
…d of the property setter (#5781) * Avoid heap corruption issue by setting the property via the DP instead of the property setter. * Disable setting the property on 19h1 and 19h2 * reenable set by DP to test with repo project
|
🎉 Handy links: |
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An OS bug was fixed in 20h1 that resolved the heap corruption bug our code is hitting on 19h1 and 19h2. Fixes #5435