Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix NavigationViewItem attempting to go to a non existant reveal state. #6317

Merged
merged 1 commit into from
Nov 16, 2021
Merged

Fix NavigationViewItem attempting to go to a non existant reveal state. #6317

merged 1 commit into from
Nov 16, 2021

Conversation

StephenLPeters
Copy link
Contributor

Tested by changing the MuxControlsTestApp FocusVisualKind to reveal, noting the broken visualization. Implementing the fix and noting the fix.

Fixes #5892

@StephenLPeters
Fix NavigationViewItem attempting to go to a non existant reveal state.
282a959 
Tested by changing the MuxControlsTestApp FocusVisualKind to reveal, noting the broken visualization. Implementing the fix and noting the fix.
@ghost ghost added the needs-triage Issue needs to be triaged by the area owners label Nov 16, 2021
@StephenLPeters
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

ranjeshj
ranjeshj approved these changes Nov 16, 2021
View reviewed changes
Copy link
Contributor

@ranjeshj ranjeshj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@zhuxb711
Copy link
Contributor

Also fixes #5274

@StephenLPeters StephenLPeters added area-NavigationView NavView control team-Controls Issue for the Controls team and removed needs-triage Issue needs to be triaged by the area owners labels Nov 16, 2021
@StephenLPeters StephenLPeters added this to the Winui 2.7.1 milestone Nov 16, 2021
@StephenLPeters StephenLPeters merged commit 2562ac6 into main Nov 16, 2021
@StephenLPeters StephenLPeters deleted the user/stpete/FixNavigationViewTopNavRevealFocus branch November 16, 2021 17:53
This was referenced Nov 16, 2021
Closed
Closed
@suilevap
Copy link

suilevap commented Apr 7, 2022

Any plans to fix it in v2.7?
So far I see it mentinoed in 2.7.1 milestone(https://github.com/microsoft/microsoft-ui-xaml/milestone/13), but only Microsoft.UI.Xaml v2.8.0-prerelease.220118001 has it in change logs (https://github.com/microsoft/microsoft-ui-xaml/releases)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ranjeshj ranjeshj ranjeshj approved these changes

Assignees
No one assigned
Labels
area-NavigationView NavView control team-Controls Issue for the Controls team
Projects
None yet
Milestone
WinUI 2.7.1
Development

Successfully merging this pull request may close these issues.

NavigationView does not work
4 participants
@StephenLPeters @zhuxb711 @suilevap @ranjeshj