Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-picking a NavigationView crash fix to 2.7 #7592

Conversation

llongley
Copy link
Member

This cherry-picks #6240 to 2.7, which is needed to fix a crash related to NavigationView.

StephenLPeters and others added 2 commits August 10, 2022 20:32
…ing cleanup. (#6240)

* Update NavigationView to track which items get a revokers object attached to them and to revoke those during deconstructing. Additionally ensure that the NavigationViewItemRevokers dependency property is only initialized once.

* Add an std::call_once block to the DP registration.
@ghost ghost added the needs-triage Issue needs to be triaged by the area owners label Aug 11, 2022
@llongley llongley requested a review from kmahone August 11, 2022 23:58
@llongley
Copy link
Member Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@llongley llongley merged commit b692263 into release/2.7 Aug 15, 2022
@llongley llongley deleted the user/llongley/CherryPick3ac8fc1843da345afb51025be393a5f67ac3ce6d branch August 15, 2022 20:25
@ranjeshj ranjeshj added area-NavigationView NavView control team-Controls Issue for the Controls team and removed needs-triage Issue needs to be triaged by the area owners labels Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-NavigationView NavView control team-Controls Issue for the Controls team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants