Improve text scale support on TextBox and NavigationView buttons #9644
+10
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microsoft-github-policy-service
bot
added
the
needs-triage
|
@microsoft-github-policy-service agree |
michael-hawker
added a commit
to michael-hawker/WinUI-Gallery
that referenced
this pull request
Mar 20, 2025
3 tasks
niels9001
pushed a commit
to microsoft/WinUI-Gallery
that referenced
this pull request
Mar 20, 2025
<!--- Provide a general summary of your changes in the Title above --> ## Description Related to microsoft/microsoft-ui-xaml#9644 Current with text scaling:  With change, it stays the same (like the other buttons do). <!--- Describe your changes in detail --> ## Motivation and Context <!--- Why is this change required? What problem does it solve? --> <!--- If it fixes an open issue, please link to the issue here. --> ## How Has This Been Tested? <!--- Please describe in detail how you tested your changes. --> <!--- Include details of your testing environment, and the tests you ran to --> <!--- see how your change affects other areas of the code, etc. --> ## Screenshots (if appropriate): ## Types of changes <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: --> - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change)
|
Thanks @United600 for the PR and your contribution, I ported this over to the internal repository that is mirrored here. It is now in the codebase that will be shipping with Windows App SDK 1.8. |
Thanks. It's unfortunate that it doesn't meet the required threshold (IMHO accessibility should) for updating down-level to WinUI 2 as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some TexBlocks with glyphs don't properly ignore the system text scale accessibility setting and, for the NavigationView search button, can scale beyond the control limits. The design guidance.
Description
Disable
IsTextScaleFactorEnabledon theNavigationViewPaneSearchButtonStyle, ported back from WinUI 3.microsoft-ui-xaml/controls/dev/NavigationView/NavigationView_themeresources.xaml
Line 343 in 2a60e27
Disable
IsTextScaleFactorEnabledon the RevealButtonstyle for the PasswordBox control.Disable
IsTextScaleFactorEnabledon the DeleteButtonStyle for the TextBox/NumberBox/PasswordBox/AutoSuggestBox controlsMotivation and Context
Provide better accessibility text size support.
How Has This Been Tested?
Created a test app WinUI 2 with and without the changes.
Screenshots (if appropriate):