Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Codicons broken in shadow dom #2140

Closed
alexdima opened this issue Sep 19, 2020 · 0 comments
Closed

Codicons broken in shadow dom #2140

alexdima opened this issue Sep 19, 2020 · 0 comments
Assignees
@alexdima @aeschli
Labels
bug Issue identified by VS Code Team member as probable bug editor-shadow-dom important Issue identified as high-priority
Milestone
August 2020

Comments

@alexdima
Copy link
Member

alexdima commented Sep 19, 2020 •
edited
Loading

Observe that a <style> tag is created in the <head> of the document and not in the shadow root that hosts the document. This came in via microsoft/vscode@8e96333

image

image
@alexdima alexdima added this to the August 2020 milestone Sep 19, 2020
@alexdima alexdima added bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority editor-shadow-dom labels Sep 19, 2020
This was referenced Sep 21, 2020
Merged
Closed
alexdima added a commit to microsoft/vscode that referenced this issue Sep 21, 2020
@alexdima
Fixes microsoft/monaco-editor#2140: Do not create a global style shee…
29ce77d 
…t unless needed
@alexdima alexdima self-assigned this Sep 21, 2020
alexdima added a commit to microsoft/vscode that referenced this issue Sep 21, 2020
@alexdima
Fixes microsoft/monaco-editor#2140: Do not create a global style shee…
0707a19 
…t unless needed
meganrogge pushed a commit to meganrogge/vscode that referenced this issue Sep 22, 2020
@alexdima @meganrogge
Fixes microsoft/monaco-editor#2140: Do not create a global style shee…
79ae072 
…t unless needed
@aeschli aeschli mentioned this issue Nov 4, 2020
Closed
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@alexdima alexdima

@aeschli aeschli

Labels
bug Issue identified by VS Code Team member as probable bug editor-shadow-dom important Issue identified as high-priority
Projects
None yet
Milestone
August 2020
Development

No branches or pull requests
2 participants
@alexdima @aeschli