Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Python f-string syntax support #4401

Merged
merged 9 commits into from
May 17, 2024

Conversation

samstrohkorbatt
Copy link
Contributor

Adding Python f-string support, as mentioned in issue: microsoft/monaco-languages#1762

This includes new tests for the f-string formatting, and all current string tests are passing, so these changes are isolated to only f-strings

@samstrohkorbatt
Copy link
Contributor Author

@microsoft-github-policy-service agree [company="{AT&T}"]

@samstrohkorbatt
Copy link
Contributor Author

@microsoft-github-policy-service agree company="AT&T"

@samstrohkorbatt
Copy link
Contributor Author

Hi @hediet and @alexdima,
Would either of you two be able to review this PR? It's been open for 2 weeks without any feedback so far

Best,
Sam

@samstrohkorbatt
Copy link
Contributor Author

Hi @rzhao271, @hediet, and @alexdima,
Could any of you review this PR? It's been open for 6 weeks now and no one has provided any feedback yet

Best,
Sam

@hediet hediet added this to the May 2024 milestone May 17, 2024
@hediet hediet enabled auto-merge May 17, 2024 09:57
@hediet
Copy link
Member

hediet commented May 17, 2024

Thanks for the PR! And sorry for the delay.

@hediet hediet merged commit a845ff6 into microsoft:main May 17, 2024
3 checks passed
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Aug 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants