This repository has been archived by the owner on Nov 5, 2021. It is now read-only.
fix rust raw string highlighting #2552 #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathanrreed
changed the title
|
Thank you! Can you add some tests? |
|
@hediet it looks like only one of the commits from this PR was merged. Raw string highlighting is still broken in |
That would be very concerning. Can you investigate what happened? |
|
@hediet I was wrong about only one of the commits being merged, it's more complicated. The git history around #146 and #147 is pretty confusing. It looks like the history between the two is intertwined and #147 un-did most of the changes in #146. For example: I'll make a follow up PR to fix it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where rust raw strings were not highlighted
microsoft/monaco-editor#2552