Skip to content
This repository has been archived by the owner on Nov 5, 2021. It is now read-only.

add tokenizer for graphql language variables #78

Merged
merged 2 commits into from
Jan 14, 2020

Conversation

acao
Copy link
Contributor

@acao acao commented Jan 14, 2020

thought i would add a tokenizer that adds a bit more definition. let me know what you think of my useage of the identifiers? we basically have typed, named function parameters.

adding this for our upcoming custom monaco-graphql, and for other folks using monaco with graphql language.

the next PR I'll come up with will be to add a tokenizer that targets just the argument names (the names in the named parameters)

before:
Screen Shot 2020-01-13 at 10 36 06 PM

after:
Screen Shot 2020-01-13 at 5 26 54 PM

@msftclas
Copy link

msftclas commented Jan 14, 2020

CLA assistant check
All CLA requirements met.

@acao acao changed the title add tokenizer for graphql language variables and fields add tokenizer for graphql language variables Jan 14, 2020
@alexdima
Copy link
Member

👍 Thank you!

@alexdima alexdima added this to the December 2019 milestone Jan 14, 2020
@alexdima alexdima merged commit 0994d67 into microsoft:master Jan 14, 2020
@acao
Copy link
Contributor Author

acao commented Jan 14, 2020

thank you! dang, that was fast!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants