Merge pull request #791 from yitam/fixODBC13tests

For these AKV tests check env despite not AE connected
microsoft · Jun 7, 2018 · 90c6443 · 90c6443
2 parents 5a66610 + f6e450b
commit 90c6443
Show file tree

Hide file tree

Showing 8 changed files with 36 additions and 6 deletions.
diff --git a/test/functional/pdo_sqlsrv/pdo_ae_azure_key_vault_client_secret.phpt b/test/functional/pdo_sqlsrv/pdo_ae_azure_key_vault_client_secret.phpt
@@ -1,7 +1,7 @@
 --TEST--
 Test client ID/secret credentials for Azure Key Vault for Always Encrypted.
 --SKIPIF--
-<?php require('skipif_mid-refactor.inc'); ?>
+<?php require('skipif_not_akv.inc'); ?>
 --FILE--
 <?php
 require_once('pdo_ae_azure_key_vault_common.php');

diff --git a/test/functional/pdo_sqlsrv/pdo_ae_azure_key_vault_keywords.phpt b/test/functional/pdo_sqlsrv/pdo_ae_azure_key_vault_keywords.phpt
@@ -1,7 +1,7 @@
 --TEST--
 Test connection keywords for Azure Key Vault for Always Encrypted.
 --SKIPIF--
-<?php require('skipif_mid-refactor.inc'); ?>
+<?php require('skipif_not_akv.inc'); ?>
 --FILE--
 <?php
 require_once('pdo_ae_azure_key_vault_common.php');

diff --git a/test/functional/pdo_sqlsrv/pdo_ae_azure_key_vault_username_password.phpt b/test/functional/pdo_sqlsrv/pdo_ae_azure_key_vault_username_password.phpt
@@ -1,7 +1,7 @@
 --TEST--
 Test username/password credentials for Azure Key Vault for Always Encrypted.
 --SKIPIF--
-<?php require('skipif_mid-refactor.inc'); ?>
+<?php require('skipif_not_akv.inc'); ?>
 --FILE--
 <?php
 require_once('pdo_ae_azure_key_vault_common.php');

diff --git a/test/functional/pdo_sqlsrv/skipif_not_akv.inc b/test/functional/pdo_sqlsrv/skipif_not_akv.inc
@@ -0,0 +1,15 @@
+<?php
+if (!extension_loaded("pdo") || !extension_loaded('pdo_sqlsrv')) {
+    die("PDO driver cannot be loaded; skipping test.\n");
+}
+
+require_once("MsSetup.inc");
+require_once("MsCommon_mid-refactor.inc");
+
+$dsn = getDSN($server, null);
+$conn = new PDO($dsn, $uid, $pwd);
+if (! $conn) {
+    echo("Error: could not connect during SKIPIF!");
+} elseif (!isAEQualified($conn)) {
+    die("skip - AE feature not supported in the current environment.");
+}
diff --git a/test/functional/sqlsrv/skipif_not_akv.inc b/test/functional/sqlsrv/skipif_not_akv.inc
@@ -0,0 +1,15 @@
+<?php
+
+if (! extension_loaded("sqlsrv")) {
+    die("skip extension not loaded");
+}
+
+require_once('MsCommon.inc');
+
+$conn = AE\connect();
+if (! $conn) {
+    echo("Error: could not connect during SKIPIF!");
+} elseif (!AE\isQualified($conn)) {
+    die("skip - AE feature not supported in the current environment.");
+}
+?>
diff --git a/test/functional/sqlsrv/sqlsrv_ae_azure_key_vault_client_secret.phpt b/test/functional/sqlsrv/sqlsrv_ae_azure_key_vault_client_secret.phpt
@@ -1,7 +1,7 @@
 --TEST--
 Test client ID/secret credentials for Azure Key Vault for Always Encrypted.
 --SKIPIF--
-<?php require('skipif_versions_old.inc'); ?>
+<?php require('skipif_not_akv.inc'); ?>
 --FILE--
 <?php
 require_once('sqlsrv_ae_azure_key_vault_common.php');

diff --git a/test/functional/sqlsrv/sqlsrv_ae_azure_key_vault_keywords.phpt b/test/functional/sqlsrv/sqlsrv_ae_azure_key_vault_keywords.phpt
@@ -1,7 +1,7 @@
 --TEST--
 Test connection keywords for Azure Key Vault for Always Encrypted.
 --SKIPIF--
-<?php require('skipif_versions_old.inc'); ?>
+<?php require('skipif_not_akv.inc'); ?>
 --FILE--
 <?php
 require_once('sqlsrv_ae_azure_key_vault_common.php');

diff --git a/test/functional/sqlsrv/sqlsrv_ae_azure_key_vault_username_password.phpt b/test/functional/sqlsrv/sqlsrv_ae_azure_key_vault_username_password.phpt
@@ -1,7 +1,7 @@
 --TEST--
 Test username/password credentials for Azure Key Vault for Always Encrypted.
 --SKIPIF--
-<?php require('skipif_versions_old.inc'); ?>
+<?php require('skipif_not_akv.inc'); ?>
 --FILE--
 <?php
 require_once('sqlsrv_ae_azure_key_vault_common.php');