Skip to content

Commit

Permalink
Set the driver argument for getDSN to null by default (#798)
Browse files Browse the repository at this point in the history
* Added the driver argument to getDSN

* Dropped the driver argument but set to null as default

* Removed the AE condition in locale support

* Modified the AE condition for locale support
  • Loading branch information
yitam authored Jun 26, 2018
1 parent 81ff085 commit eeea787
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions test/functional/pdo_sqlsrv/MsCommon_mid-refactor.inc
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ function connect($keywords = '', $options=array(), $errmode = PDO::ERRMODE_EXCEP
* @param bool $disableCE : flag for disabling column encryption even when keystore is NOT none
* @return string dsn string used for PDO constructor
*/
function getDSN($sqlsrvserver, $database, $driver, $keywords = '', $disableCE = false)
function getDSN($sqlsrvserver, $database, $driver = null, $keywords = '', $disableCE = false)
{
require("MsSetup.inc");
$dsn = "";
Expand All @@ -85,7 +85,7 @@ function getDSN($sqlsrvserver, $database, $driver, $keywords = '', $disableCE =
if ($database) {
$dsn .= "database=$database;";
}
if ($driver) {
if (!is_null($driver)) {
$dsn .= "driver=$driver;";
}
if ($keystore != "none" && !$disableCE) {
Expand Down
2 changes: 1 addition & 1 deletion test/functional/sqlsrv/MsCommon.inc
Original file line number Diff line number Diff line change
Expand Up @@ -472,7 +472,7 @@ function isLocaleSupported()
if (isWindows()) {
return true;
}
if (AE\isColEncrypted()) {
if (AE\isDataEncrypted()) {
return false;
}
// now check ODBC version
Expand Down

0 comments on commit eeea787

Please sign in to comment.