fix for 7.4.0beta1

[remicollet]

From UPGRADE.INTERNALS

 y. The read and write operations of php_stream_ops now return ssize_t, with
     negative values indicating an error.

This si for beta1 which will be announced tomorrow

[coveralls]

Coverage remained the same at 72.342% when pulling c0ee075 on remicollet:issue-php74beta1 into 5dabd47 on microsoft:master.

[codecov-io]

Codecov Report

Merging #1013 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1013   +/-   ##
=======================================
  Coverage   80.49%   80.49%           
=======================================
  Files          25       25           
  Lines        7758     7758           
=======================================
  Hits         6245     6245           
  Misses       1513     1513

Impacted Files	Coverage Δ
...vc14/x86/php-7.1.29-src/ext/pdo_sqlsrv/pdo_dbh.cpp
...x86/php-7.1.29-src/ext/sqlsrv/shared/core_init.cpp
...php-7.1.29-src/ext/pdo_sqlsrv/shared/core_util.cpp
...c14/x86/php-7.1.29-src/ext/pdo_sqlsrv/pdo_util.cpp
...php-7.1.29-src/ext/pdo_sqlsrv/php_pdo_sqlsrv_int.h
...x86/php-7.1.29-src/ext/sqlsrv/shared/core_conn.cpp
...x86/php-7.1.29-src/ext/sqlsrv/shared/core_stmt.cpp
...php-7.1.29-src/ext/pdo_sqlsrv/shared/core_sqlsrv.h
...x86/php-7.1.29-src/ext/sqlsrv/shared/core_util.cpp
...6/php-7.1.29-src/ext/sqlsrv/shared/core_stream.cpp
... and 40 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5dabd47...c0ee075. Read the comment docs.

[nikic]

While this fixes the compilation error, I think some additional changes are needed to properly propagate errors. In particular the two return 0s in the catch blocks should become return -1 to indicate that an error happened.

[yitam]

Hi @remicollet

Many thanks for your contribution but as @nikic mentioned above, we will fix this properly to support PHP 7.4 beta. Also, we do not plan to release a preview just yet, because the preview will include new feature(s) and bug fixes.

[yitam]

For your information @remicollet we will close this pull request. For more details please see the related pull request #1015. Thanks!