Fix empty string bind param causes floating point exception

source/pdo_sqlsrv/core_stmt.cpp

@@ -1960,7 +1960,7 @@ void default_sql_size_and_scale( sqlsrv_stmt* stmt, unsigned int paramno, zval*
                 column_size = SQL_SERVER_MAX_TYPE_SIZE;
             }
             else {
-				column_size = SQL_SERVER_MAX_FIELD_SIZE / char_size;
+				column_size = (char_size == 0) ? 1 : (SQL_SERVER_MAX_FIELD_SIZE / char_size);
             }
             break;
         }

source/pdo_sqlsrv/tests/bug_141.phpt

@@ -0,0 +1,30 @@
+--TEST--
+Bug #141 (Assinging empty string as bind parameter produces floating point exception)
+--SKIPIF--
+<?php if(!extension_loaded("pdo_sqlsrv")) print "skip"; ?>
+--INI--
+--FILE--
+<?php
+require('config.inc');
+
+$dbo = new PDO("sqlsrv:server=$serverName ; Database = $database", $username, $password);
+print 'PDO sqlsrv connection successfull: '.($dbo ? 'yes' : 'no').PHP_EOL;
+
+$sth = $dbo->prepare('select ?');
+print 'PDO sqlsrv prepare successfull: '.($sth !== false ? 'yes' : 'no').PHP_EOL;
+
+$result = $sth->bindValue(1, '');
+print 'PDO sqlsrv value binding successfull: '.($result !== false ? 'yes' : 'no').PHP_EOL;
+
+$result = $sth->execute();
+print 'PDO sqlsrv execute successfull: '.($result !== false ? 'yes' : 'no').PHP_EOL;
+
+$row = $sth->fetch(PDO::FETCH_NUM);
+print 'PDO sqlsrv fetch result 1st column is empty string: ' . ($row[0] === '' ? 'yes' : 'no') . PHP_EOL;
+?>
+--EXPECT--
+PDO sqlsrv connection successfull: yes
+PDO sqlsrv prepare successfull: yes
+PDO sqlsrv value binding successfull: yes
+PDO sqlsrv execute successfull: yes
+PDO sqlsrv fetch result 1st column is empty string: yes

source/pdo_sqlsrv/tests/config.inc

@@ -0,0 +1,6 @@
+<?php
+$serverName = getenv('MSSQL_SERVERNAME') ?: 'localhost';
+$database   = getenv('MSSQL_DATABASE') ?: 'test_db';
+$username   = getenv('MSSQL_USERNAME') ?: 'test_user';
+$password   = getenv('MSSQL_PASSWORD') ?: 'test_pass';
+

source/sqlsrv/core_stmt.cpp

@@ -1960,7 +1960,7 @@ void default_sql_size_and_scale( sqlsrv_stmt* stmt, unsigned int paramno, zval*
                 column_size = SQL_SERVER_MAX_TYPE_SIZE;
             }
             else {
-				column_size = SQL_SERVER_MAX_FIELD_SIZE / char_size;
+				column_size = (char_size == 0) ? 1 : (SQL_SERVER_MAX_FIELD_SIZE / char_size);
             }
             break;
         }

source/sqlsrv/tests/bug_144.phpt

@@ -0,0 +1,25 @@
+--TEST--
+Bug #144 (PHP-7.0-Linux sqlsrv_query() produces floating point exception when bind parameter is a empty string)
+--SKIPIF--
+<?php if(!extension_loaded("sqlsrv")) print "skip"; ?>
+--INI--
+--FILE--
+<?php
+require('config.inc');
+
+$conn = sqlsrv_connect($serverName, ['Database' => $database, 'Uid' => $username, 'PWD' => $password]);
+print 'sqlsrv connection successfull: '.($conn !== false ? 'yes' : 'no').PHP_EOL;
+
+$result = sqlsrv_query($conn, 'SELECT ?', ['']);
+print 'sqlsrv parametrized query successfull: '.($result !== false ? 'yes' : 'no').PHP_EOL;
+
+$row = sqlsrv_fetch_array($result, SQLSRV_FETCH_NUMERIC);
+print 'sqlsrv parametrized query result 1st colum is empty string: ' . ($row[0] === '' ? 'yes' : 'no') . PHP_EOL;
+
+sqlsrv_free_stmt($result);
+
+?>
+--EXPECT--
+sqlsrv connection successfull: yes
+sqlsrv parametrized query successfull: yes
+sqlsrv parametrized query result 1st colum is empty string: yes

source/sqlsrv/tests/config.inc

@@ -0,0 +1,6 @@
+<?php
+$serverName = getenv('MSSQL_SERVERNAME') ?: 'localhost';
+$database   = getenv('MSSQL_DATABASE') ?: 'test_db';
+$username   = getenv('MSSQL_USERNAME') ?: 'test_user';
+$password   = getenv('MSSQL_PASSWORD') ?: 'test_pass';
+