Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For issue #231, force column size to be determined #293

Merged
merged 3 commits into from
Feb 22, 2017
Merged

For issue #231, force column size to be determined #293

merged 3 commits into from
Feb 22, 2017

Conversation

yitam
Copy link
Contributor

@yitam yitam commented Feb 17, 2017

Issue #231: When binding params, in the function determine_column_size_or_precision(), column size is set to SQL_SS_LENGTH_UNLIMITED (0). Then later in resize_output_buffer_if_necessary() when calculating the required size, the buffer length is smaller than required, which results in truncation error. This affects not only varchar(max), but also nvarchar(max), varbinary(max), and xml types

@yitam yitam requested a review from v-dareck February 17, 2017 16:12
@coveralls
Copy link

Coverage Status

Coverage increased (+1.9%) to 46.369% when pulling 909bcfe on yitam:GH231 into ff25f29 on Microsoft:dev.

@coveralls
Copy link

Coverage Status

Coverage increased (+1.7%) to 46.129% when pulling aec1c83 on yitam:GH231 into ff25f29 on Microsoft:dev.

@coveralls
Copy link

Coverage Status

Coverage increased (+1.7%) to 46.137% when pulling aec1c83 on yitam:GH231 into ff25f29 on Microsoft:dev.

@yitam yitam closed this Feb 20, 2017
@yitam yitam reopened this Feb 20, 2017
@yitam
Copy link
Contributor Author

yitam commented Feb 20, 2017

The problem described in issue #231 also affects InOut parameters, and for varbinary(max), the encoding is not set properly. The new test will test both output and inout parameters plus these data types with unlimited sizes

@coveralls
Copy link

Coverage Status

Coverage increased (+0.5%) to 46.661% when pulling 0705d9b on yitam:GH231 into cc925ad on Microsoft:dev.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.5%) to 46.661% when pulling f7a1c72 on yitam:GH231 into e448281 on Microsoft:dev.

@v-dareck v-dareck merged commit 2610243 into microsoft:dev Feb 22, 2017
@yitam yitam deleted the GH231 branch March 1, 2017 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants