Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed output to test #737

Merged
merged 1 commit into from
Apr 4, 2018
Merged

Fixed output to test #737

merged 1 commit into from
Apr 4, 2018

Conversation

david-puglielli
Copy link
Contributor

@david-puglielli david-puglielli commented Apr 4, 2018

ODBC Driver 17.1 seems to change the output slightly on mac when connection attempt fails.


This change is Reviewable

@david-puglielli david-puglielli requested a review from yitam April 4, 2018 19:26
@david-puglielli david-puglielli changed the base branch from master to dev April 4, 2018 19:27
@@ -21,7 +21,7 @@ if ($c !== false) {
?>
--EXPECTREGEX--

Fatal error: Uncaught PDOException: SQLSTATE\[(28000|08001|HYT00)\]: .*\[Microsoft\]\[ODBC Driver 1[0-9] for SQL Server\](\[SQL Server\])?(Named Pipes Provider: Could not open a connection to SQL Server \[2\]\. |Login timeout expired|Login failed for user 'sa'\.) in .+(\/|\\)pdo_utf8_conn\.php:[0-9]+
Fatal error: Uncaught PDOException: SQLSTATE\[(28000|08001|HYT00)\]: .*\[Microsoft\]\[ODBC Driver 1[0-9] for SQL Server\](\[SQL Server\])?(Named Pipes Provider: Could not open a connection to SQL Server \[2\]\. |TCP Provider: Error code 0x2AF9|Login timeout expired|Login failed for user 'sa'\.) in .+(\/|\\)pdo_utf8_conn\.php:[0-9]+
Stack trace:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so basically you added yet another possible error message?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that's the one that shows up on mac. It corresponds to WSAHOST_NOT_FOUND (no such host is known).

@coveralls
Copy link

Coverage Status

Coverage remained the same at 73.334% when pulling 54c0f5a on david-puglielli:pdo_utf8_conn-test-fix into 1958cfd on Microsoft:dev.

@codecov-io
Copy link

codecov-io commented Apr 4, 2018

Codecov Report

Merging #737 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #737   +/-   ##
=======================================
  Coverage   79.02%   79.02%           
=======================================
  Files          25       25           
  Lines        7188     7188           
=======================================
  Hits         5680     5680           
  Misses       1508     1508
Impacted Files Coverage Δ
...php-7.1.15-src/ext/pdo_sqlsrv/shared/core_init.cpp
...6/php-7.1.15-src/ext/sqlsrv/shared/core_stream.cpp
...php/x86/php-7.1.15-src/ext/pdo_sqlsrv/pdo_init.cpp
...php-7.1.15-src/ext/pdo_sqlsrv/shared/core_sqlsrv.h
...cts/php/x86/php-7.1.15-src/ext/sqlsrv/php_sqlsrv.h
...rojects/php/x86/php-7.1.15-src/ext/sqlsrv/stmt.cpp
...x86/php-7.1.15-src/ext/sqlsrv/shared/core_init.cpp
...p/x86/php-7.1.15-src/ext/pdo_sqlsrv/pdo_parser.cpp
...php-7.1.15-src/ext/pdo_sqlsrv/shared/core_conn.cpp
...rojects/php/x86/php-7.1.15-src/ext/sqlsrv/conn.cpp
... and 40 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1958cfd...54c0f5a. Read the comment docs.

@david-puglielli david-puglielli merged commit a8db024 into microsoft:dev Apr 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants