Replace most strlen with strnlen_s

[yitam]

This change is 

[coveralls]

Coverage increased (+0.006%) to 73.228% when pulling 93b9938 on yitam:strlen into c87e37f on Microsoft:dev.

[david-puglielli]

There are two definitions for strnlen_s? Why not put this line in Stringfunctions.h? Then you should be able to remove the definition from StringFunctions.cpp.

[yitam]

No this is just a macro, mainly for WIN32, because strnlen_s() is builtin. Besides, StringFunctions.h is not included in Windows build

[david-puglielli]

Ok I see.

[david-puglielli]

btw have you checked that this compiles on all platforms? I'm just a bit concerned because strnlen_s is part of the c11 standard, not c++11.

[yitam]

yes, I've run customized in Build and Functional Test plans last Friday

[codecov-io]

Codecov Report

Merging #747 into dev will increase coverage by 0.05%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##              dev     #747      +/-   ##
==========================================
+ Coverage   78.86%   78.91%   +0.05%     
==========================================
  Files          25       25              
  Lines        7149     7157       +8     
==========================================
+ Hits         5638     5648      +10     
+ Misses       1511     1509       -2

Impacted Files	Coverage Δ
...php-7.1.16-src/ext/pdo_sqlsrv/shared/core_sqlsrv.h	80.14% <0%> (ø)	⬆️
.../php/x86/php-7.1.16-src/ext/pdo_sqlsrv/pdo_dbh.cpp	92.3% <0%> (+0.05%)	⬆️
...php-7.1.16-src/ext/pdo_sqlsrv/shared/core_stmt.cpp	65.06% <0%> (+0.07%)	⬆️
...x86/php-7.1.16-src/ext/sqlsrv/shared/core_stmt.cpp	83.8% <0%> (+0.09%)	⬆️
...php-7.1.16-src/ext/pdo_sqlsrv/shared/core_conn.cpp	86.97% <0%> (+0.09%)	⬆️
...x86/php-7.1.16-src/ext/sqlsrv/shared/core_conn.cpp	81.33% <0%> (+0.13%)	⬆️
...x86/php-7.1.16-src/ext/sqlsrv/shared/core_sqlsrv.h	83.65% <0%> (+0.19%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c87e37f...93b9938. Read the comment docs.