Made changes to output param handling code to convert doubles to ints, if necessary #761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #761 +/- ##
==========================================
+ Coverage 78.85% 79.12% +0.26%
==========================================
Files 25 25
Lines 7157 7175 +18
==========================================
+ Hits 5644 5677 +33
+ Misses 1513 1498 -15
Continue to review full report at Codecov.
|
| @@ -406,8 +406,8 @@ pdo_error PDO_ERRORS[] = { | |||
| { IMSSP, (SQLCHAR*) "Stored Procedures do not support text, ntext or image as OUTPUT parameters.", -83, false } | |||
| }, | |||
| { | |||
| SQLSRV_ERROR_ENCRYPTED_STREAM_FETCH, | |||
| { IMSSP, (SQLCHAR*) "Connection with Column Encryption enabled does not support fetching stream. Please fetch the data as a string.", -84, false } | |||
There was a problem hiding this comment.
This error is not needed anymore?
There was a problem hiding this comment.
Yes, it's an obsolete error message that is no longer needed
| // a long integer first to take care of rounding | ||
| convert_to_long(value_z); | ||
| if (output_param->is_bool) { | ||
| convert_to_boolean(value_z); |
There was a problem hiding this comment.
Does this mean that if the value as a double is 0.1, the corresponding boolean is false?
david-puglielli
approved these changes
May 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #707
This change is