Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified the test to address VSO 2915 #774

Merged
merged 1 commit into from
May 16, 2018
Merged

Modified the test to address VSO 2915 #774

merged 1 commit into from
May 16, 2018

Conversation

yitam
Copy link
Contributor

@yitam yitam commented May 15, 2018

This change is Reviewable

@coveralls
Copy link

coveralls commented May 15, 2018

Coverage Status

Coverage remained the same at 73.151% when pulling 0a11136 on yitam:vso2915 into 63c85ed on Microsoft:dev.

@codecov-io
Copy link

codecov-io commented May 16, 2018

Codecov Report

Merging #774 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #774   +/-   ##
=======================================
  Coverage   78.92%   78.92%           
=======================================
  Files          25       25           
  Lines        7213     7213           
=======================================
  Hits         5693     5693           
  Misses       1520     1520

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63c85ed...0a11136. Read the comment docs.

// See VSO 2915 for details. The string must be a numeric
// string, and to make it work for all precisions, we
// simply set it to a single-digit string.
$det = $rand = '0';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this limitation in our driver or is it in PDO?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neither, for inout param to work, the variable must be a numeric string because ODBC attempts to convert the string input to a decimal (in this test). If it was an empty string or non-numerical, ODBC will return with this error Error converting data type nvarchar to numeric.

Likewise, for decimal columns with precision (1,0), it can only take a single-digit string as input, or ODBC will also return a similar error. For decimal columns with higher precision, say (4,0), then you can provide a string like "123", etc. I decided to use a simple single-digit str input that works for all precisions.

@yitam yitam merged commit 30a9708 into microsoft:dev May 16, 2018
@yitam yitam deleted the vso2915 branch May 16, 2018 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants