Modified the test to address VSO 2915 #774
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #774 +/- ##
=======================================
Coverage 78.92% 78.92%
=======================================
Files 25 25
Lines 7213 7213
=======================================
Hits 5693 5693
Misses 1520 1520Continue to review full report at Codecov.
|
| // See VSO 2915 for details. The string must be a numeric | ||
| // string, and to make it work for all precisions, we | ||
| // simply set it to a single-digit string. | ||
| $det = $rand = '0'; |
There was a problem hiding this comment.
Is this limitation in our driver or is it in PDO?
There was a problem hiding this comment.
Neither, for inout param to work, the variable must be a numeric string because ODBC attempts to convert the string input to a decimal (in this test). If it was an empty string or non-numerical, ODBC will return with this error Error converting data type nvarchar to numeric.
Likewise, for decimal columns with precision (1,0), it can only take a single-digit string as input, or ODBC will also return a similar error. For decimal columns with higher precision, say (4,0), then you can provide a string like "123", etc. I decided to use a simple single-digit str input that works for all precisions.
This change is