Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bigint insertion bug in x86 #777

Merged
merged 3 commits into from
May 24, 2018
Merged

Fixed bigint insertion bug in x86 #777

merged 3 commits into from
May 24, 2018

Conversation

david-puglielli
Copy link
Contributor

@david-puglielli david-puglielli commented May 23, 2018

This change is Reviewable

@david-puglielli david-puglielli requested a review from yitam May 23, 2018 22:44
@coveralls
Copy link

coveralls commented May 23, 2018

Coverage Status

Coverage remained the same at 74.697% when pulling 1edd16d on david-puglielli:bigint-x86-test-fix into e0f9afa on Microsoft:dev.

@codecov-io
Copy link

codecov-io commented May 23, 2018

Codecov Report

Merging #777 into dev will increase coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #777      +/-   ##
==========================================
+ Coverage   79.99%   80.06%   +0.06%     
==========================================
  Files          25       25              
  Lines        7323     7323              
==========================================
+ Hits         5858     5863       +5     
+ Misses       1465     1460       -5
Impacted Files Coverage Δ
...php-7.1.17-src/ext/pdo_sqlsrv/shared/core_conn.cpp 87.06% <0%> (+1.43%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0f9afa...1edd16d. Read the comment docs.

Copy link
Contributor

@yitam yitam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please modify BIGINT values in two values.php

@@ -792,7 +792,7 @@
52.7878,
-1.79E+308,
-3.4E+38,
-987654321987654321,
PHP_INT_SIZE == 4 ? "-9223372036854775807" : -9223372036854775807,
987654321,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for both 32bit and 64 bit bigint values should be quoted as strings because even though it passed in 64 bit accuracy might be lost

Copy link
Contributor

@yitam yitam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please insert BIGINT values as strings in both 32bit and 64bit systems. Otherwise approved.

@david-puglielli david-puglielli merged commit 5c46d4b into microsoft:dev May 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants