-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed bigint insertion bug in x86 #777
Fixed bigint insertion bug in x86 #777
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #777 +/- ##
==========================================
+ Coverage 79.99% 80.06% +0.06%
==========================================
Files 25 25
Lines 7323 7323
==========================================
+ Hits 5858 5863 +5
+ Misses 1465 1460 -5
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please modify BIGINT values in two values.php
@@ -792,7 +792,7 @@ | |||
52.7878, | |||
-1.79E+308, | |||
-3.4E+38, | |||
-987654321987654321, | |||
PHP_INT_SIZE == 4 ? "-9223372036854775807" : -9223372036854775807, | |||
987654321, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for both 32bit and 64 bit bigint values should be quoted as strings because even though it passed in 64 bit accuracy might be lost
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please insert BIGINT values as strings in both 32bit and 64bit systems. Otherwise approved.
This change is