Added the driver option to run functional tests #793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #793 +/- ##
=======================================
Coverage 80.06% 80.06%
=======================================
Files 25 25
Lines 7325 7325
=======================================
Hits 5865 5865
Misses 1460 1460Continue to review full report at Codecov.
|
| @@ -8,30 +8,6 @@ | |||
|
|
|||
There was a problem hiding this comment.
Where is the code below going? Is it already in MsCommon_mid-refactor.inc?
There was a problem hiding this comment.
yes, these were old and not used anymore
| // Do not assume the master key must be the first one created | ||
| $found = false; | ||
| while ($master_key_row = $stmt->fetch()) { | ||
| if ($master_key_row[0] == 'AEMasterKey') { |
There was a problem hiding this comment.
These key names are the defaults? Are these the names they get created with in our setup scripts?
There was a problem hiding this comment.
yes, by the AE setup scripts
david-puglielli
approved these changes
Jun 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the Driver option to the functional tests
Cleaned up pdo_sqlsrv\MsCommon.inc
Fixed the two test_ae_keys_setup tests
This change is