Skipif fix #821
Merged
Skipif fix #821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o dev Merging upstream/dev to origin
yitam
reviewed
Jul 23, 2018
| } else { | ||
| if ($msodbcsql_maj < 17) { | ||
| die("skip Unsupported ODBC driver version"); | ||
| } |
There was a problem hiding this comment.
Suggestion: change this to
if (!$is_win) {
if ($msodbcsql_maj < 17) {
die("skip Unsupported ODBC driver version");
} else {
// $msodbcsql_maj >= 17
if ($msodbcsql_maj == 17 && $msodbcsql_min < 2 ) {
die...
}
}
}
Codecov Report
@@ Coverage Diff @@
## dev #821 +/- ##
==========================================
- Coverage 80.06% 80.05% -0.02%
==========================================
Files 25 25
Lines 7325 7321 -4
==========================================
- Hits 5865 5861 -4
Misses 1460 1460
Continue to review full report at Codecov.
|
yitam
reviewed
Jul 24, 2018
| } | ||
| } | ||
| } else { | ||
| if ($msodbcsql_maj < 17) { | ||
| die("skip Unsupported ODBC driver version"); |
There was a problem hiding this comment.
Why is the else clause still necessary?
yitam
approved these changes
Jul 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is