Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed load order issue in sqlsrv #925

Merged
merged 1 commit into from
Feb 6, 2019
Merged

Fixed load order issue in sqlsrv #925

merged 1 commit into from
Feb 6, 2019

Conversation

david-puglielli
Copy link
Contributor

@david-puglielli david-puglielli commented Feb 5, 2019 •
edited
Loading

Have tested all load order combinations and they all work:
Two shared files: pdo+sqlsrv, sqlsrv+pdo, pdo only, sqlsrv only
one static+one shared: pdo shared, sqlsrv shared
both static

@coveralls
Copy link

Coverage Status

Coverage remained the same at 72.4% when pulling 9e49a17 on david-puglielli:shared-compilation-load-order-fix into d9b6e05 on Microsoft:dev.

yitam
yitam approved these changes Feb 6, 2019
View reviewed changes
Copy link
Contributor

@yitam yitam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved upon the passing of all tests

@david-puglielli david-puglielli merged commit d69015c into microsoft:dev Feb 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yitam yitam yitam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@david-puglielli @coveralls @yitam