Grab a UDP Port Reservation #2017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nibanks
added
OS: Windows (User)
Bug: Platform
|
Can interference happen between kernel and user in this same way? Is there a way to add this behavior in kernel as well? |
Kernel mode doesn't use the per-processor socket option, so I believe it doesn't have the same problem. |
thhous-msft
approved these changes
Sep 21, 2021
anrossi
approved these changes
Sep 21, 2021
|
I thought you needed to associate each socket with the port reservation with SIO_ASSOCIATE_PORT_RESERVATION before binding? |
It doesn't look like we do? I'm not getting any bind failures on the other sockets? What should I do? |
maolson-msft
approved these changes
Sep 21, 2021
|
Marking as blocked on a crash this seems to be hitting. |
|
This is now fixed and good to go. The QuicInterop failure unrelated. |
thhous-msft
added a commit
that referenced
this pull request
Oct 7, 2021
This reverts commit 8d14aba.
thhous-msft
added a commit
that referenced
this pull request
Oct 7, 2021
Wizmann
added a commit
to Wizmann/msquic
that referenced
this pull request
Nov 17, 2021
code done minor refine fix compiling compile done, error on running compile done, error on running bugfix try fix bug bugfix remove test code fix style Run more BVT and SpinQuic on windows-2022 (microsoft#2028) Rework issue templates (microsoft#2030) YAML-based issue forms (microsoft#2031) * Merge from pivotman319/issue-templates-rework-2 * Merge from pivotman319/issue-templates-rework-2 * Update bug_report.yaml * Add label "feature request" As requested by @nibanks * fix label * Final touches * Remove validations on additional OS info Add error code and docs for invalid address error (microsoft#2032) Co-authored-by: Nick Banks <nibanks@microsoft.com> Publish Docker Image to GitHub Registry (microsoft#2038) Build linux binaries in onebranch (microsoft#2042) Co-authored-by: Nick Banks <nibanks@microsoft.com> Fix onebranch official pipeline (microsoft#2043) Grab a UDP Port Reservation (microsoft#2017) Co-authored-by: Thad House <thhous@microsoft.com> Move/Rename QNS Dockerfile (microsoft#2040) Correctly Handle FIN after Stream Reset (microsoft#2049) Fix Flow Control Assert (microsoft#2050) Fix clog sidecar printing out port in reverse order (microsoft#2051) Fix CLOG sidecar (microsoft#2053) Trigger a test pipeline from the onebranch pipelines (microsoft#2054) * Add trigger tests * Fix main trigger * Add test file * Test triggering from onebranch pipeline * Test distribution again * Print out env vars * one more artifact thing * More distribution test * Add the rest of the triggers back in * Some more triggering * Some more cleanup * Fix CI again * Hopefully just 1 last fix * 1 more linux fix... * Fix a few low hanging things Sign Linux Packages (microsoft#2055) Move Check CLOG to Action (microsoft#2059) Enable Linux Signing Preview (microsoft#2058) Use default container for ubuntu signing (microsoft#2062) Revert "Grab a UDP Port Reservation (microsoft#2017)" (microsoft#2065) This reverts commit 8d14aba. Generate vpacks from onebranch binaries (microsoft#2067) Disable perf tests until we can repair perf systems (microsoft#2068) * Disable perf tests until we can repair perf systems * Disable post process Run WAN Perf on WS2022 (microsoft#2061) Run Kernel BVT on WS2022 (microsoft#2064) Fix onebranch test pipelines having wrong dependency order (microsoft#2069) * Fix onebranch test pipelines having wrong dependency order * Fix winkernel name Add tls provider to onebranch kernel mode build task (microsoft#2070) Fix Connection FC Handling on Stream Abort (microsoft#2066) Fix update sidecar script to work on non windows platforms (microsoft#2072) fix clog and PROBE_RTT bug fix comments fix compile error fix clog compile error, and add TODO try fix sidecar build error fix compile error fix driver compile error by replace float to uint32_t update ci pipeline for wan tests try fix ci script fix comments fix comments fix clog and compile fix comments try fix ci pipeline try fix run-wanperf.yml bugfix for bbr bugfix for SendQuantum try fix wan perf problem by refine pacing temporarily disable pacing to check the performance (will revert later) try fix wan perf for bbr fix MeasuredBw big bug fix for kExpectedStartupGrowth and TotalBytesSentAtLastAck enable deep buffer test bugfix for SendRate use uint32_t to replace uint64_t for loss_detection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explicitly grab a UDP port reservation to make sure other processes fail to use the same port in parallel.