Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't Check Minor Version in Test #2949

Merged
merged 1 commit into from
Aug 5, 2022
Merged

Conversation

nibanks
Copy link
Member

@nibanks nibanks commented Aug 5, 2022

Description

We can't test the minor version because it will 100% fail when run as a down-level test. To support running this with future versions of MsQuic, just validate the major version.

Testing

Tests updated

Documentation

N/A

@nibanks nibanks requested a review from a team as a code owner August 5, 2022 13:58
@nibanks nibanks added the Area: Testing Related to test coverage label Aug 5, 2022
@nibanks nibanks enabled auto-merge (squash) August 5, 2022 14:02
@nibanks nibanks merged commit bd062c3 into release/2.1 Aug 5, 2022
@nibanks nibanks deleted the nibanks/dont-test-minor-ver branch August 5, 2022 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Testing Related to test coverage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants