Update Linux Packages to Depend on libnuma #3670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nibanks
commented
Jun 2, 2023
| @@ -182,6 +183,7 @@ if [ "$OS" == "linux" ]; then | |||
| --provides ${NAME} \ | |||
| --conflicts ${CONFLICTS} \ | |||
| --depends "libssl${TLSVERSION}" \ | |||
| --depends "libnuma1" \ | |||
There was a problem hiding this comment.
@wfurt I did a combination of guessing and chatgpt to come up with these changes. Would it be possible to get your help validating?
There was a problem hiding this comment.
[root@061eeb412ce3 /]# yum provides libnuma.so.1
Last metadata expiration check: 0:04:56 ago on Fri Jun 2 22:12:46 2023.
numactl-libs-2.0.16-2.fc38.i686 : libnuma libraries
Repo : fedora
Matched from:
Provide : libnuma.so.1
root@f45c0dbd52df:~/msquic# apt-cache depends libnuma1
libnuma1
Depends: libc6
Looks good to me at least. Both dependency names can be recognized.
csujedihy
approved these changes
Jun 2, 2023
csujedihy
pushed a commit
that referenced
this pull request
Jun 8, 2023
* Update Linux Packages to Depend on libnuma * Update Linux Packages to Depend on libnuma
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #3421.
Testing
Existing automation covers some of this.
Documentation
N/A