Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass Through Disable AIA Flag #4674

Merged
merged 3 commits into from
Dec 4, 2024
Merged

Pass Through Disable AIA Flag #4674

merged 3 commits into from
Dec 4, 2024

Conversation

nibanks
Copy link
Member

@nibanks nibanks commented Dec 3, 2024

Description

Adds a new QUIC_CREDENTIAL_FLAGS that allows for disabling AIA retrivials.

Testing

Updated

Documentation

Updated

Copy link

codecov bot commented Dec 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.65%. Comparing base (698c028) to head (5390425).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4674      +/-   ##
==========================================
+ Coverage   86.19%   86.65%   +0.46%     
==========================================
  Files          56       56              
  Lines       17361    17361              
==========================================
+ Hits        14964    15044      +80     
+ Misses       2397     2317      -80     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ami-GS
Copy link
Contributor

ami-GS commented Dec 3, 2024

What does AIA mean?

@nibanks
Copy link
Member Author

nibanks commented Dec 3, 2024

What does AIA mean?

I don't actually know. 😆 All the docs I saw just referenced AIA retrieval for client cert stuff.

But I just did a search and found this: https://learn.microsoft.com/en-us/windows-server/networking/core-network-guide/cncg/server-certs/configure-the-cdp-and-aia-extensions-on-ca1

Seems AIA = Authority Information Access

Copy link
Contributor

@anrossi anrossi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@nibanks nibanks merged commit 9c41c71 into main Dec 4, 2024
480 of 482 checks passed
@nibanks nibanks deleted the disable-AIA branch December 4, 2024 00:00
nibanks added a commit that referenced this pull request Dec 4, 2024
nibanks added a commit that referenced this pull request Dec 4, 2024
nibanks added a commit that referenced this pull request Dec 4, 2024
nibanks added a commit that referenced this pull request Dec 4, 2024
nibanks added a commit that referenced this pull request Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants