Rust: Rename QUIC_ERROR to QUIC_STATUS #4765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
QUIC_ERROR was used in generated code originally because QUIC_STATUS is already occupied as a c macro type. Many msquic struct has the fields "status: QUIC_ERROR" and "error: u62", so this is confusing as why error field is not QUIC_ERROR?
This PR replaces QUIC_ERROR with the ideal name QUIC_STATUS to align perfectly with the C code. The wrapper.hpp gets a bit ugly but it produces the correct generated rust code.
Testing
Existing error code tests are changed to accommodate this rename.
Documentation
NA