Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print MSSQL* events to stdout #31

Merged
merged 2 commits into from
Feb 8, 2017
Merged

Conversation

jelster
Copy link

@jelster jelster commented Feb 6, 2017

As a user, I want to be able to view SQL-related event log entries without having to docker exec powershell get-winevent or similar.

PR adds display of events (via Get-EventLog) matching the Source filter of MSSQL*. I arbitrarily selected 2s as the refresh interval for logs because I wasn't sure if setting it lower (e.g., 1s) would have negative implications.

@gigatexal
Copy link

Does docker logs -f do anything similar?

@jelster
Copy link
Author

jelster commented Feb 6, 2017

@gigatexal - docker log only displays what's written to stdout; because the PR change writes event log entries to stdout, running docker log -f with this will display event log entries.

@gigatexal
Copy link

That's awesome and a very welcome addition.

@jelster
Copy link
Author

jelster commented Feb 6, 2017

Totally! I haven't seen any other samples use this, so I almost feel like there's got to be some catch that I'm not aware of.

@gigatexal
Copy link

Let's see if it gets merged. If not I'm sure they'll let us know if you missed something.

@jelster
Copy link
Author

jelster commented Feb 8, 2017

This PR could resolve (at least in part) #16

@perrysk-msft
Copy link
Collaborator

{Merged PR} Thanks for the contribution @jelster

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants