Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature | Added caching for Always Encrypted with secure enclaves #1189

Merged
merged 26 commits into from
Dec 7, 2019
Merged

Feature | Added caching for Always Encrypted with secure enclaves #1189

merged 26 commits into from
Dec 7, 2019

Conversation

rene-ye
Copy link
Member

@rene-ye rene-ye commented Nov 22, 2019 •
edited
Loading

Adds the following

  • AAS Enclave Provider
  • AAS/VSM Certificate cache
  • Enclave Session cache

@rene-ye
Add AAS provider
3b099d9
@rene-ye
Merge branch 'dev' of https://github.com/Microsoft/mssql-jdbc into ae…
5871fc8 
…Regression

# Conflicts:
#	src/main/java/com/microsoft/sqlserver/jdbc/SQLServerConnection.java
#	src/main/java/com/microsoft/sqlserver/jdbc/SQLServerVSMEnclaveProvider.java
@rene-ye
add caches
a3471ff
@rene-ye
Remove weird connection formatting
d8b9366
@rene-ye
format
a46fa16
@rene-ye
Fix test
b275112
@rene-ye
Fix to connection
f11188a
@rene-ye
Change hashmap to hashtable
488837c
lilgreenbird
lilgreenbird reviewed Nov 27, 2019
View reviewed changes
src/main/java/com/microsoft/sqlserver/jdbc/SQLServerAASEnclaveProvider.java
}

@Override
public void invalidateEnclaveSession() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this still isn't used, when do we need to call this?

lilgreenbird
lilgreenbird reviewed Nov 27, 2019
View reviewed changes
src/main/java/com/microsoft/sqlserver/jdbc/SQLServerAASEnclaveProvider.java
if (null == rs) {
// No results. Meaning no parameter.
// Should never happen.
return enclaveRequestedCEKs;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we log something?

lilgreenbird
lilgreenbird reviewed Nov 27, 2019
View reviewed changes
src/main/java/com/microsoft/sqlserver/jdbc/SQLServerAASEnclaveProvider.java
}


class JWTCertificateEntry {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

general comment (applies elsewhere too)
Can we add comments to these classes? I know they're not public so no need for javadocs, but would be nice to have some descriptions on what these are

@ulvii ulvii requested review from peterbae and ulvii November 29, 2019 21:21
@ulvii ulvii added this to the 8.1.1 milestone Nov 29, 2019
@ulvii ulvii changed the title Caching for AEv2 Feature | Added caching for Always Encrypted with secure enclaves Dec 4, 2019
@lilgreenbird lilgreenbird mentioned this pull request Dec 5, 2019
Closed
@ulvii ulvii merged commit 77f9f10 into microsoft:dev Dec 7, 2019
ulvii pushed a commit that referenced this pull request Mar 3, 2020
@rene-ye @ulvii
Feature | Added caching for Always Encrypted with secure enclaves (#1189
2bc048f 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterbae peterbae peterbae left review comments

@lilgreenbird lilgreenbird lilgreenbird left review comments

@ulvii ulvii ulvii approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
8.1.1
Development

Successfully merging this pull request may close these issues.
4 participants
@rene-ye @lilgreenbird @ulvii @peterbae