Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving buildParamTypeDefinitions performance #1938

Merged
merged 3 commits into from
May 25, 2023
Merged

Improving buildParamTypeDefinitions performance #1938

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
29a9849
Improving prepared statment performance
cogman Oct 21, 2022
cbeafae
Merge branch 'main' into main
cogman May 16, 2023
b355250
Move renew before pulling type definition
cogman May 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 36 additions & 15 deletions src/main/java/com/microsoft/sqlserver/jdbc/SQLServerPreparedStatement.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -422,31 +422,52 @@ private boolean buildPreparedStrings(Parameter[] params, boolean renewDefinition
* @return the required data type definitions.
*/
private String buildParamTypeDefinitions(Parameter[] params, boolean renewDefinition) throws SQLServerException {
StringBuilder sb = new StringBuilder();
int nCols = params.length;
if (nCols == 0)
return "";

// Output looks like @P0 timestamp, @P1 varchar
int stringLen = nCols * 2; // @P
stringLen += nCols; // spaces
stringLen += nCols -1; // commas
if (nCols > 10)
stringLen += 10 + ((nCols - 10) * 2); // @P{0-99} Numbers after p
else
stringLen += nCols; // @P{0-9} Numbers after p less than 10

// Computing the type definitions up front, so we can get exact string lengths needed for the string builder.
String[] typeDefinitions = new String[nCols];
for (int i = 0; i < nCols; i++) {
Parameter param = params[i];
param.renewDefinition = renewDefinition;
String typeDefinition = param.getTypeDefinition(connection, resultsReader());
if (null == typeDefinition) {
MessageFormat form = new MessageFormat(SQLServerException.getErrString("R_valueNotSetForParameter"));
Object[] msgArgs = {i + 1};
SQLServerException.makeFromDriverError(connection, this, form.format(msgArgs), null, false);
}
typeDefinitions[i] = typeDefinition;
stringLen += typeDefinition.length();

// While we are getting type definitions, check if the params are output and extend the builder if so.
stringLen += param.isOutput() ? 7 : 0;
}

StringBuilder sb = new StringBuilder(stringLen);
char[] cParamName = new char[10];
parameterNames = new ArrayList<>();
parameterNames = new ArrayList<>(nCols);

for (int i = 0; i < nCols; i++) {
if (i > 0)
sb.append(',');

int l = SQLServerConnection.makeParamName(i, cParamName, 0);
for (int j = 0; j < l; j++)
sb.append(cParamName[j]);
String parameterName = String.valueOf(cParamName, 0, l);
sb.append(parameterName);
sb.append(' ');

parameterNames.add(i, (new String(cParamName)).trim());

params[i].renewDefinition = renewDefinition;
String typeDefinition = params[i].getTypeDefinition(connection, resultsReader());
if (null == typeDefinition) {
MessageFormat form = new MessageFormat(SQLServerException.getErrString("R_valueNotSetForParameter"));
Object[] msgArgs = {i + 1};
SQLServerException.makeFromDriverError(connection, this, form.format(msgArgs), null, false);
}

sb.append(typeDefinition);
parameterNames.add(parameterName);
sb.append(typeDefinitions[i]);

if (params[i].isOutput())
sb.append(" OUTPUT");
Expand Down