Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re-interrupt the current thread, in order to restore the thread's interrupt status. #204

Merged
merged 3 commits into from
Mar 29, 2017

Conversation

xiangyushawn
Copy link
Contributor

for issue #196

@codecov-io
Copy link

codecov-io commented Mar 14, 2017

Codecov Report

Merging #204 into dev will decrease coverage by 0.14%.
The diff coverage is 75%.

@@             Coverage Diff              @@
##                dev     #204      +/-   ##
============================================
- Coverage     32.89%   32.75%   -0.15%     
+ Complexity     1435     1429       -6     
============================================
  Files            97       97              
  Lines         23359    23387      +28     
  Branches       3881     3889       +8     
============================================
- Hits           7684     7660      -24     
- Misses        14138    14183      +45     
- Partials       1537     1544       +7
Flag Coverage Δ Complexity Δ
#JDBC41 32.68% <75%> (-0.1%) 1426 <0> (-2)
#JDBC42 32.69% <75%> (-0.14%) 1429 <0> (-3)
Impacted Files Coverage Δ Complexity Δ
...om/microsoft/sqlserver/jdbc/SQLServerBulkCopy.java 44.91% <100%> (-0.11%) 181 <0> (-2)
...in/java/com/microsoft/sqlserver/jdbc/IOBuffer.java 36.25% <100%> (-0.16%) 0 <0> (ø)
.../microsoft/sqlserver/jdbc/SQLServerConnection.java 40.15% <50%> (+0.05%) 204 <0> (ø) ⬇️
...a/com/microsoft/sqlserver/jdbc/PLPInputStream.java 33.13% <0%> (-1.19%) 23% <0%> (-1%)
...oft/sqlserver/jdbc/SQLServerParameterMetaData.java 19.78% <0%> (-1.11%) 27% <0%> (ø)
...m/microsoft/sqlserver/jdbc/SQLServerResultSet.java 23.27% <0%> (-1.06%) 165% <0%> (-10%)
...t/sqlserver/jdbc/SQLServerConnectionPoolProxy.java 12.62% <0%> (ø) 12% <0%> (ø) ⬇️
...a/com/microsoft/sqlserver/jdbc/ParameterUtils.java 62.22% <0%> (+15.55%) 19% <0%> (+7%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e24866c...b3686e6. Read the comment docs.

Copy link
Contributor

@v-nisidh v-nisidh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we come up some JUnit test case for testing this?
I am referring to original problem.

Encountered a situation where a piece of code was calling cancel(true) on a future runnable but upon inspection Thead.currentThead().isInterrupted() was returning false inside the runnable

@xiangyushawn xiangyushawn merged commit 82c62ec into microsoft:dev Mar 29, 2017
@xiangyushawn xiangyushawn deleted the restore-interrupt-status branch March 29, 2017 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants