Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-added support for stored procedure 'exec' escape syntax in CallableStatements #2325

Merged
merged 12 commits into from
Feb 15, 2024
Merged

Re-added support for stored procedure 'exec' escape syntax in CallableStatements #2325

merged 12 commits into from
Feb 15, 2024

Conversation

tkyc
Copy link
Contributor

@tkyc tkyc commented Feb 8, 2024 •
edited
Loading

Prior to 12.6.0, all cstmts calls were wrapped int T-SQL sp_executesql, sp_prepexec etc.. calls before being sent off to the server. Doing so means the raw/unprocessed user's sql was passed into these T-SQL calls as parameter values and so the driver was able to execute "EXEC" calls against the server eg. EXEC sp_columns_100 ?,?,?,?.....

For example:

exec sp_executesql N'EXEC sp_getapplock @Resource=@P0, @LockTimeout='3600000', @LockMode='Exclusive', @LockOwner='Session',N'@P0 nvarchar(4000)',N'testParamValue'

This PR enables this prior behaviour again.

#2323

@lilgreenbird lilgreenbird linked an issue Feb 9, 2024 that may be closed by this pull request
mssql-jdbc:12.6.0.jre11 - 'sp_getapplock' expects parameter '@LockMode' #2323
Closed
@lilgreenbird lilgreenbird added this to the 12.6.1 milestone Feb 9, 2024
lilgreenbird
lilgreenbird previously approved these changes Feb 9, 2024
View reviewed changes
lilgreenbird
lilgreenbird reviewed Feb 13, 2024
View reviewed changes
Copy link
Contributor

@lilgreenbird lilgreenbird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change the title to something more descriptive instead of just regression fix

@tkyc tkyc changed the title EXEC system stored procedure regression fix Re-added support for stored procedure 'exec' escape syntax in CallableStatements Feb 13, 2024
David-Engel
David-Engel previously approved these changes Feb 13, 2024
View reviewed changes
@tkyc tkyc merged commit ba88da8 into main Feb 15, 2024
17 checks passed
@tkyc tkyc deleted the sp-regression-fix branch February 15, 2024 22:26
tkyc added a commit that referenced this pull request Feb 15, 2024
@tkyc
Re-added support for stored procedure 'exec' escape syntax in Callabl…
b2947c5 
…eStatements (#2325)

* EXEC system stored procedure regression fix

* Additional test

* Additional test

* Indenting

* Switched error string to TestResource error string

* CR comments

* Test update p1

* Test update p2

* CR comment changes; Test update

* call escape syntax check

* CR changes

* formatting
@tkyc tkyc mentioned this pull request Feb 15, 2024
Merged
tkyc added a commit that referenced this pull request Feb 17, 2024
@tkyc
Re-added support for stored procedure 'exec' escape syntax in Callabl…
e2685b4 
…eStatements (#2325) (#2329)

* EXEC system stored procedure regression fix

* Additional test

* Additional test

* Indenting

* Switched error string to TestResource error string

* CR comments

* Test update p1

* Test update p2

* CR comment changes; Test update

* call escape syntax check

* CR changes

* formatting
@olerabanal olerabanal mentioned this pull request Feb 21, 2024
Closed
@olerabanal
Copy link

I cannot see #2325 in the release notes of 12.6.1 ? @tkyc

@tkyc
Copy link
Contributor Author

tkyc commented Feb 21, 2024

@olerabanal #2329 is the backport of this PR to 12.6, which is in the release notes.

Jeffery-Wasty added a commit that referenced this pull request Aug 6, 2024
@Jeffery-Wasty
Revert "Re-added support for stored procedure 'exec' escape syntax in…
b7b8fa9 
… CallableStatements (#2325) (#2329)"

This reverts commit e2685b4.
tkyc added a commit that referenced this pull request Aug 13, 2024
@tkyc
Revert "Re-added support for stored procedure 'exec' escape syntax in…
70ac59f 
… CallableStatements (#2325)"

This reverts commit ba88da8.
@tkyc tkyc mentioned this pull request Aug 14, 2024
Merged
tkyc added a commit that referenced this pull request Aug 21, 2024
@tkyc
Revert Execute Stored Procedure directly feature (#2488)
4c6227a 
* Revert "Execute Stored Procedures Directly (#2154)"

This reverts commit 11680a6.

* Revert "Execute cstmt directly - Additional testing and changes (#2284)"

This reverts commit 92cfe0d.

* Revert "Re-added support for stored procedure 'exec' escape syntax in CallableStatements (#2325)"

This reverts commit ba88da8.

* Additional revert of missed lines

* Added no-op for getters/setters

* RequestBoundaryMethods no-op test fix
tkyc added a commit that referenced this pull request Aug 21, 2024
@tkyc
Revert Execute Stored Procedure directly feature (#2488)
7b2d4a6 
* Revert "Execute Stored Procedures Directly (#2154)"

This reverts commit 11680a6.

* Revert "Execute cstmt directly - Additional testing and changes (#2284)"

This reverts commit 92cfe0d.

* Revert "Re-added support for stored procedure 'exec' escape syntax in CallableStatements (#2325)"

This reverts commit ba88da8.

* Additional revert of missed lines

* Added no-op for getters/setters

* RequestBoundaryMethods no-op test fix
@tkyc tkyc mentioned this pull request Aug 21, 2024
Merged
tkyc added a commit that referenced this pull request Aug 22, 2024
@tkyc
Revert Execute Stored Procedure directly feature (#2488) (#2494)
21d236a 
* Revert "Execute Stored Procedures Directly (#2154)"

This reverts commit 11680a6.

* Revert "Execute cstmt directly - Additional testing and changes (#2284)"

This reverts commit 92cfe0d.

* Revert "Re-added support for stored procedure 'exec' escape syntax in CallableStatements (#2325)"

This reverts commit ba88da8.

* Additional revert of missed lines

* Added no-op for getters/setters

* RequestBoundaryMethods no-op test fix
tkyc added a commit that referenced this pull request Aug 23, 2024
@tkyc
Revert Execute Stored Procedure directly feature (#2488)
f2f3f17 
* Revert "Execute Stored Procedures Directly (#2154)"

This reverts commit 11680a6.

* Revert "Execute cstmt directly - Additional testing and changes (#2284)"

This reverts commit 92cfe0d.

* Revert "Re-added support for stored procedure 'exec' escape syntax in CallableStatements (#2325)"

This reverts commit ba88da8.

* Additional revert of missed lines

* Added no-op for getters/setters

* RequestBoundaryMethods no-op test fix
@tkyc tkyc mentioned this pull request Aug 23, 2024
Merged
tkyc added a commit that referenced this pull request Aug 28, 2024
@tkyc
Revert Execute Stored Procedure directly feature (#2488) (#2500)
07f02b3 
* Revert "Execute Stored Procedures Directly (#2154)"

This reverts commit 11680a6.

* Revert "Execute cstmt directly - Additional testing and changes (#2284)"

This reverts commit 92cfe0d.

* Revert "Re-added support for stored procedure 'exec' escape syntax in CallableStatements (#2325)"

This reverts commit ba88da8.

* Additional revert of missed lines

* Added no-op for getters/setters

* RequestBoundaryMethods no-op test fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jeffery-Wasty Jeffery-Wasty Jeffery-Wasty approved these changes

@lilgreenbird lilgreenbird lilgreenbird approved these changes

@David-Engel David-Engel David-Engel left review comments

@barryw-mssql barryw-mssql Awaiting requested review from barryw-mssql

Assignees
No one assigned
Labels
None yet
Projects
MSSQL JDBC
Status: Closed/Merged PRs
Milestone
12.6.1
Development

Successfully merging this pull request may close these issues.

mssql-jdbc:12.6.0.jre11 - 'sp_getapplock' expects parameter '@LockMode'
5 participants
@tkyc @olerabanal @lilgreenbird @Jeffery-Wasty @David-Engel