-
Notifications
You must be signed in to change notification settings - Fork 427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix SqlAuthenticationToken constructor accepting unix epoch #2425
Conversation
@barryw-mssql @tkyc Could you help to review this fix? |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2425 +/- ##
============================================
+ Coverage 50.08% 50.10% +0.01%
- Complexity 3832 3838 +6
============================================
Files 145 145
Lines 33396 33394 -2
Branches 5662 5662
============================================
+ Hits 16728 16732 +4
+ Misses 14269 14265 -4
+ Partials 2399 2397 -2 ☔ View full report in Codecov by Sentry. |
@konjac Thanks for the PR, we'll take a look at it and get back to you with our thoughts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hold off on merging for a bit
This is to address #2424