Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SqlAuthenticationToken constructor accepting unix epoch #2425

Merged
merged 3 commits into from
May 22, 2024

Conversation

konjac
Copy link
Contributor

@konjac konjac commented May 22, 2024

This is to address #2424

@konjac
Copy link
Contributor Author

konjac commented May 22, 2024

@barryw-mssql @tkyc Could you help to review this fix?

Copy link

codecov bot commented May 22, 2024

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 50.10%. Comparing base (a35798e) to head (b4e6543).
Report is 1 commits behind head on main.

Current head b4e6543 differs from pull request most recent head 6b8d308

Please upload reports for the commit 6b8d308 to get more accurate results.

Files Patch % Lines
...oft/sqlserver/jdbc/SQLServerCallableStatement.java 0.00% 2 Missing and 1 partial ⚠️
...osoft/sqlserver/jdbc/SQLServerSecurityUtility.java 0.00% 2 Missing ⚠️
...m/microsoft/sqlserver/jdbc/SQLServerStatement.java 0.00% 0 Missing and 1 partial ⚠️
...a/com/microsoft/sqlserver/jdbc/StreamRetValue.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2425      +/-   ##
============================================
+ Coverage     50.08%   50.10%   +0.01%     
- Complexity     3832     3838       +6     
============================================
  Files           145      145              
  Lines         33396    33394       -2     
  Branches       5662     5662              
============================================
+ Hits          16728    16732       +4     
+ Misses        14269    14265       -4     
+ Partials       2399     2397       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

barryw-mssql
barryw-mssql previously approved these changes May 22, 2024
@Jeffery-Wasty
Copy link
Contributor

@konjac Thanks for the PR, we'll take a look at it and get back to you with our thoughts.

@Jeffery-Wasty Jeffery-Wasty added this to the 12.7.1 milestone May 22, 2024
tkyc
tkyc previously approved these changes May 22, 2024
Copy link
Contributor

@Jeffery-Wasty Jeffery-Wasty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hold off on merging for a bit

@tkyc tkyc dismissed stale reviews from barryw-mssql and themself via 85791a6 May 22, 2024 19:05
tkyc
tkyc previously approved these changes May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Closed/Merged PRs
Development

Successfully merging this pull request may close these issues.

Implementation bug in SqlAuthenticationToken constructor accepting unix epoch
4 participants