Updated getIndexInfo() to include Columnstore indexes by using custom query. #2566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2566 +/- ##
============================================
+ Coverage 51.12% 51.21% +0.08%
+ Complexity 3940 3933 -7
============================================
Files 147 147
Lines 33456 33512 +56
Branches 5604 5612 +8
============================================
+ Hits 17105 17162 +57
+ Misses 13963 13930 -33
- Partials 2388 2420 +32 ☔ View full report in Codecov by Sentry. |
Ananya2
requested review from
lilgreenbird,
divang,
Jeffery-Wasty,
tkyc and
machavan
divang
reviewed
Dec 17, 2024
src/main/java/com/microsoft/sqlserver/jdbc/SQLServerDatabaseMetaData.java
Outdated
Show resolved
Hide resolved
divang
reviewed
Dec 17, 2024
src/main/java/com/microsoft/sqlserver/jdbc/SQLServerDatabaseMetaData.java
Outdated
Show resolved
Hide resolved
src/main/java/com/microsoft/sqlserver/jdbc/SQLServerDatabaseMetaData.java
Outdated
Show resolved
Hide resolved
...est/java/com/microsoft/sqlserver/jdbc/databasemetadata/DatabaseMetadataGetIndexInfoTest.java
Outdated
Show resolved
Hide resolved
...est/java/com/microsoft/sqlserver/jdbc/databasemetadata/DatabaseMetadataGetIndexInfoTest.java
Outdated
Show resolved
Hide resolved
...est/java/com/microsoft/sqlserver/jdbc/databasemetadata/DatabaseMetadataGetIndexInfoTest.java
Show resolved
Hide resolved
...est/java/com/microsoft/sqlserver/jdbc/databasemetadata/DatabaseMetadataGetIndexInfoTest.java
Outdated
Show resolved
Hide resolved
...est/java/com/microsoft/sqlserver/jdbc/databasemetadata/DatabaseMetadataGetIndexInfoTest.java
Outdated
Show resolved
Hide resolved
...est/java/com/microsoft/sqlserver/jdbc/databasemetadata/DatabaseMetadataGetIndexInfoTest.java
Outdated
Show resolved
Hide resolved
...est/java/com/microsoft/sqlserver/jdbc/databasemetadata/DatabaseMetadataGetIndexInfoTest.java
Outdated
Show resolved
Hide resolved
...est/java/com/microsoft/sqlserver/jdbc/databasemetadata/DatabaseMetadataGetIndexInfoTest.java
Outdated
Show resolved
Hide resolved
lilgreenbird
reviewed
Jan 7, 2025
...est/java/com/microsoft/sqlserver/jdbc/databasemetadata/DatabaseMetadataGetIndexInfoTest.java
Show resolved
Hide resolved
divang
previously approved these changes
Jan 8, 2025
tkyc
previously approved these changes
Jan 8, 2025
|
Might want to manually test this on Azure DW. I don't think there should be problems, but just as a check. |
* Capture Client Guest OS and architecture in JDBC
* Added app name with format Microsoft JDBC - {os}, {platform} - {arch}
* Adding log info and getAppNameWithProperties()
* Updated the application name to be set dynamically
* Added log level as FINE
* Added test case to verify application name
* Updated the SQLServerDriverPropertyInfo with default name
* Added static block for initialization
* Added test case for code coverage
* Updated app Name
* Driver cuts out the question mark from columns labels (aliases) * added SQLServerPreparedStatement
* Fix OffsetDateTime conversion for pre-Gregorian dates * Formatting changes * Removed unused import
* Handled failure in getApplicationName() * Added test to validate appName using select app_name() query * Updated connect property * Updated connect property to add appname * Fixed checking of APPLICATION_NAME in connect properties * Added test case --------- Co-authored-by: machavan <machavan@microsoft.com>
|
/azp run public-mssql-jdbc.windows |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run public-mssql-jdbc.linux |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run CI-MacOS |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced the use of the sp_statistics stored procedure with a custom query to retrieve index information as the sp_statistics procedure did not return Columnstore indexes, so a query using sys.indexes was implemented as a workaround.
This new query ensures that all index types (Clustered, NonClustered, Columnstore) are included in the result set.
Github Issue: #2546