Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sslprotocol #325

Closed
wants to merge 4 commits into from
Closed

Sslprotocol #325

wants to merge 4 commits into from

Conversation

v-nisidh
Copy link
Contributor

@v-nisidh v-nisidh commented Jun 1, 2017

Please DO NOT MERGE. This Pull Request is only for review for approach taken for IBM FIPS & SSL Protocol

v-nisidh added 4 commits May 10, 2017 18:58
Initial check in for configurable SSLProtocols
Added parametrized test cases
In IBM FIPS environment IBM JRE expects FIPSProvider should be read from
JVM config files.
Disabled some test for FIPS env. due to change in logic. Need to write
tests for FIPS
@v-nisidh
Copy link
Contributor Author

v-nisidh commented Jun 1, 2017

Please find attach files for test purpose.

Shared_Files.zip

@codecov-io
Copy link

codecov-io commented Jun 2, 2017

Codecov Report

Merging #325 into dev will decrease coverage by 0.11%.
The diff coverage is 52.38%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev     #325      +/-   ##
============================================
- Coverage     37.26%   37.14%   -0.12%     
+ Complexity     1764     1762       -2     
============================================
  Files           107      107              
  Lines         24491    24507      +16     
  Branches       4000     4001       +1     
============================================
- Hits           9127     9104      -23     
- Misses        13653    13698      +45     
+ Partials       1711     1705       -6
Flag Coverage Δ Complexity Δ
#JDBC41 37.05% <52.38%> (-0.11%) 1757 <0> (-3)
#JDBC42 37.01% <52.38%> (-0.14%) 1753 <0> (-5)
Impacted Files Coverage Δ Complexity Δ
...om/microsoft/sqlserver/jdbc/SQLServerResource.java 100% <ø> (ø) 4 <0> (ø) ⬇️
.../microsoft/sqlserver/jdbc/SQLServerDataSource.java 43.51% <0%> (-3.9%) 59 <0> (-7)
.../com/microsoft/sqlserver/jdbc/SQLServerDriver.java 74.18% <100%> (+0.23%) 25 <0> (ø) ⬇️
.../microsoft/sqlserver/jdbc/SQLServerConnection.java 44.62% <28.57%> (+0.03%) 255 <0> (+1) ⬆️
...in/java/com/microsoft/sqlserver/jdbc/IOBuffer.java 43.45% <75%> (-0.87%) 0 <0> (ø)
...java/com/microsoft/sqlserver/jdbc/StringUtils.java 0% <0%> (-60%) 2% <0%> (-2%)
...rc/main/java/com/microsoft/sqlserver/jdbc/DDC.java 29.24% <0%> (-1.12%) 55% <0%> (-1%)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a12a39...11ea2c7. Read the comment docs.

@v-nisidh
Copy link
Contributor Author

v-nisidh commented Jul 7, 2017

This pull request consists of adding configurable SSLProtocol and removing FIPS validation.

Please create 2 different pull requests for SSLProtocol & removing FIPS validation

@xiangyushawn xiangyushawn self-requested a review July 17, 2017 22:46
@ulvii
Copy link
Contributor

ulvii commented Jul 31, 2017

Hi @v-nisidh/ @nsidhaye

I created a new PR that adds sslProtocol connection property. Planing to create another one for FIPS validation. Please feel free to leave your feedback :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants