JDK9 Compatibility + JDBC 4.3 API addition #601

cheenamalhotra · 2018-01-09T23:00:12Z

This Pull Request:

Makes the driver compatible to be compiled with Java 9 JVM.
Introduces JDBC 4.3 APIs added with Java 9.
Builds jre9 driver jars.
Drops building jre7 jars.

…javadoc pluggin.

…a 8 and lower.

…ose not implemented yet. Also updated the jdbc file to include building jre8 jar.

# Conflicts: # pom.xml

Update JDBC4.3 branch with latest changes from Dev branch

Java 9 Updates for JDBC4.3 branch only

…sion

Update samples in JDBC 4.3 branch

Removal of deprecated APIs and update travic script with jdk 9

…BC4.3 # Conflicts: # src/test/java/com/microsoft/sqlserver/jdbc/preparedStatement/BatchExecutionWithNullTest.java

Update JDBC4.3 branch with latest dev changes

Merging dev to JDBC4.3 with static modifier changes

…ed APIs

Update JDBC4.3 branch with using 43wrapper

& is not allowed in error strings or parsing fails.

codecov-io · 2018-01-09T23:28:04Z

Codecov Report

Merging #601 into dev will increase coverage by 0.31%.
The diff coverage is 49.54%.

@@             Coverage Diff             @@
##               dev     #601      +/-   ##
===========================================
+ Coverage     46.5%   46.82%   +0.31%     
- Complexity    2211     2315     +104     
===========================================
  Files          108      109       +1     
  Lines        25320    26390    +1070     
  Branches      4177     4533     +356     
===========================================
+ Hits         11775    12356     +581     
- Misses       11515    11921     +406     
- Partials      2030     2113      +83

Flag	Coverage Δ	Complexity Δ
#JDBC41	`?`	`?`
#JDBC42	`46.73% <46.29%> (+0.35%)`	`2311 <6> (+105)`	⬆️
#JDBC43	`46.71% <45.45%> (?)`	`2314 <6> (?)`

Impacted Files	Coverage Δ	Complexity Δ
...om/microsoft/sqlserver/jdbc/SQLServerResource.java	`100% <ø> (ø)`	`4 <0> (ø)`	⬇️
...m/microsoft/sqlserver/jdbc/SQLServerResultSet.java	`32.95% <ø> (+0.21%)`	`243 <0> (+2)`	⬆️
.../com/microsoft/sqlserver/jdbc/SQLServerSQLXML.java	`12.8% <0%> (-0.11%)`	`9 <0> (ø)`
...erverColumnEncryptionCertificateStoreProvider.java	`0% <0%> (ø)`	`0 <0> (ø)`	⬇️
...soft/sqlserver/jdbc/SQLServerDatabaseMetaData.java	`36.03% <0%> (-0.13%)`	`55 <0> (ø)`
...rc/main/java/com/microsoft/sqlserver/jdbc/dtv.java	`63.08% <0%> (+0.39%)`	`0 <0> (ø)`	⬇️
...om/microsoft/sqlserver/jdbc/SQLServerBulkCopy.java	`52.67% <0%> (+0.09%)`	`240 <0> (+1)`	⬆️
.../java/com/microsoft/sqlserver/jdbc/SqlVariant.java	`88.33% <0%> (ø)`	`13 <0> (ø)`	⬇️
...m/microsoft/sqlserver/jdbc/SQLServerStatement.java	`59.73% <0%> (+0.08%)`	`134 <0> (+1)`	⬆️
...icrosoft/sqlserver/jdbc/SQLServerXAConnection.java	`0% <0%> (ø)`	`0 <0> (ø)`	⬇️
... and 34 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d15edb...5669308. Read the comment docs.

NersesAM · 2018-02-16T19:32:43Z

Any chance you will do a new release soon? It will be great to have Java 9 compatibility released soon as without it, it is not possible to upgrade apps to 9

cheenamalhotra · 2018-02-16T19:50:33Z

Hi @NersesAM
Yes, we are proceeding to release soon. Stay tuned!

NersesAM · 2018-02-16T19:53:16Z

great! thanks @cheenamalhotra

NersesAM · 2018-02-27T23:53:00Z

hi @cheenamalhotra
The README says 6.4.0.jre9 can be used but it's not available in maven central. That was merged 11 days ago? When do you think you will be able to release it to maven central?

cheenamalhotra · 2018-02-27T23:57:46Z

Hi @NersesAM
It will be available on Maven Central in next few hours.. we have published the artifacts on Maven :)

The release artifacts are also available in Download Center here.

NersesAM · 2018-02-28T00:00:09Z

great! thank you @cheenamalhotra
tomorrow i can finally upgrade to java 9!

AfsanehR-zz and others added 30 commits September 24, 2017 20:14

removing java.xml.bind dependency

40edfde

removed dependency of java.xml.bind and updated pom file with latest …

380ab87

…javadoc pluggin.

disabled appveyor and updated travic to use java 9

04e4a0b

Fixed NoSuchMethodError when compiling with Java 9 but running on jav…

0b094dc

…a 8 and lower.

add support for JDBC 4.3 APIs and throw unsupported exceptions for th…

022d747

…ose not implemented yet. Also updated the jdbc file to include building jre8 jar.

fixed the javadoc warnings.

98f9f65

update SQLServerJdbc41 to throw unsupportedError for 4.3 APIs

7ed782d

remove apache code for encoder and remove 4.1 compaitble jars

1c389e8

Merge branch 'dev' of https://github.com/Microsoft/mssql-jdbc into Java9

8ef32d8

# Conflicts: # pom.xml

Merge pull request #565 from Microsoft/dev

6f9fec6

Update JDBC4.3 branch with latest changes from Dev branch

updated dependency versions in pom file for jdbc 4.3 branch

778d3ee

Merge pull request #566 from v-afrafi/Java9

8c7f465

Java 9 Updates for JDBC4.3 branch only

update samples in JDBC 4.3 branch + change the the junit.platform.ver…

27b9414

…sion

Merge pull request #570 from v-afrafi/Java9

b1dbacc

Update samples in JDBC 4.3 branch

remove deprecated APIs

7ec7356

add more catch blocks for new getDeclaredConstructor method.

3a21346

update Travis script with official support of jdk 9

9540cce

fix comment

24486c9

update readme file

47ddc43

Merge pull request #577 from v-afrafi/Java9

7a2bbef

Removal of deprecated APIs and update travic script with jdk 9

Merge branch 'dev' of https://github.com/Microsoft/mssql-jdbc into JD…

5846c8f

…BC4.3 # Conflicts: # src/test/java/com/microsoft/sqlserver/jdbc/preparedStatement/BatchExecutionWithNullTest.java

Merge pull request #586 from v-afrafi/JDBC4.3

29a8a3a

Update JDBC4.3 branch with latest dev changes

Merge pull request #587 from Microsoft/dev

84fb8c5

Merging dev to JDBC4.3 with static modifier changes

use wrapper for sharding APIs

257d6e1

fix another issue with Java 9 regarding bulkcopy connection check

6a833eb

added another fix

4b28d70

added cast to Buffer

19d8a51

change Base64.getEncoder().encodeToString()

99868e6

Make sure the right wrapper is used for 4.2 and above.

b9fc801

make SQLServerConnection43 throw SQLServerException for new Unsupport…

8faa912

…ed APIs

AfsanehR-zz and others added 3 commits December 21, 2017 13:33

Merge pull request #589 from v-afrafi/JDBC4.3_Wrapper

9f3dedd

Update JDBC4.3 branch with using 43wrapper

& is not allowed in error strings or parsing fails.

daa647c

Merge pull request #594 from peterbae/localization-jdbc4.3

16d3bb0

& is not allowed in error strings or parsing fails.

cheenamalhotra added this to the 6.4.0 milestone Jan 9, 2018

cheenamalhotra requested review from ulvii and peterbae January 9, 2018 23:01

cheenamalhotra mentioned this pull request Jan 18, 2018

MS SQL JDBC driver 6.2 does not work with Java 9 #549

Closed

AfsanehR-zz approved these changes Jan 23, 2018

View reviewed changes

Merge branch 'dev' into JDBC4.3

5669308

AfsanehR-zz merged commit e0e70a4 into dev Jan 23, 2018

cheenamalhotra deleted the JDBC4.3 branch February 26, 2018 23:20

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

JDK9 Compatibility + JDBC 4.3 API addition #601

JDK9 Compatibility + JDBC 4.3 API addition #601

cheenamalhotra commented Jan 9, 2018

codecov-io commented Jan 9, 2018 •

edited

Loading

NersesAM commented Feb 16, 2018

cheenamalhotra commented Feb 16, 2018

NersesAM commented Feb 16, 2018

NersesAM commented Feb 27, 2018

cheenamalhotra commented Feb 27, 2018

NersesAM commented Feb 28, 2018

JDK9 Compatibility + JDBC 4.3 API addition #601

JDK9 Compatibility + JDBC 4.3 API addition #601

Conversation

cheenamalhotra commented Jan 9, 2018

codecov-io commented Jan 9, 2018 • edited Loading

Codecov Report

NersesAM commented Feb 16, 2018

cheenamalhotra commented Feb 16, 2018

NersesAM commented Feb 16, 2018

NersesAM commented Feb 27, 2018

cheenamalhotra commented Feb 27, 2018

NersesAM commented Feb 28, 2018

codecov-io commented Jan 9, 2018 •

edited

Loading