Changes in preparation for 6.5.1 preview release #670

rene-ye · 2018-04-06T19:55:56Z

Updates to POM, README, CHANGELOG, and Driver version.

Retry logic

To help debug an irreproducable/random mismatch error if it occurs in the future.

…#666) * Dont throw exception for colmetadata token * Adding a comment * Update comment * Adding a warning message * remove ignoreLengthPrefixedToken

* Added more information to error messages To help debug an irreproducable/random mismatch error if it occurs in the future. * Revert "Added information to error message" This reverts commit 25301e6. * Fix for microsoft#659 Added error handling logic for special cases. * Read message length Read the message length instead of reading until terminating character * Unsigned byte update Message length is an unsigned byte, converting before using. * Removed clunky hex conversions convert the byte straight to an int and use existing constants instead of making new ones * Narrowed trigger conditions fixed an issue where column names who had the hex token 'AA' would cause an error to be thrown. * Spacing fixes * Added test case * spacing adjustment * Edited test drop procedures Changed IF EXISTS DROP commands to be compatible with sql server 2008 * github spacing misalignment fixes * Changed test condition now only runs on compatible database or higher * Removed error check Removed a previous implementation in favor of one that changes the TDS parser * tdsreader change * removing test for now * enabled tests * github spacing fix * removed array import * removed "arrays" instead of "array" * spacing changes

…crosoft#662)

pull

Implement a more generic and compatible test in the future

Used in removed test

codecov-io · 2018-04-06T20:12:38Z

Codecov Report

Merging #670 into dev will decrease coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                dev     #670      +/-   ##
============================================
- Coverage     48.18%   48.16%   -0.02%     
- Complexity     2575     2577       +2     
============================================
  Files           113      113              
  Lines         26587    26587              
  Branches       4436     4436              
============================================
- Hits          12810    12806       -4     
- Misses        11645    11653       +8     
+ Partials       2132     2128       -4

Flag	Coverage Δ	Complexity Δ
#JDBC42	`48.08% <ø> (-0.02%)`	`2573 <ø> (+3)`
#JDBC43	`48.04% <ø> (+0.06%)`	`2571 <ø> (+3)`	⬆️

Impacted Files	Coverage Δ	Complexity Δ
...a/com/microsoft/sqlserver/jdbc/SQLJdbcVersion.java	`0% <ø> (ø)`	`0 <0> (ø)`	⬇️
...om/microsoft/sqlserver/jdbc/ReaderInputStream.java	`44.94% <0%> (-1.13%)`	`16% <0%> (-1%)`
...in/java/com/microsoft/sqlserver/jdbc/IOBuffer.java	`54.63% <0%> (-0.67%)`	`0% <0%> (ø)`
...ncurrentlinkedhashmap/ConcurrentLinkedHashMap.java	`38.54% <0%> (-0.65%)`	`42% <0%> (-1%)`
...m/microsoft/sqlserver/jdbc/SQLServerResultSet.java	`33.14% <0%> (+0.07%)`	`245% <0%> (+1%)`	⬆️
...rc/main/java/com/microsoft/sqlserver/jdbc/dtv.java	`63.47% <0%> (+0.36%)`	`0% <0%> (ø)`	⬇️
...m/microsoft/sqlserver/jdbc/SQLServerException.java	`77.23% <0%> (+1.62%)`	`30% <0%> (+1%)`	⬆️
...rc/main/java/com/microsoft/sqlserver/jdbc/DDC.java	`45.41% <0%> (+2.23%)`	`108% <0%> (+3%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 501f2b8...30927f1. Read the comment docs.

cheenamalhotra · 2018-04-06T21:10:24Z

CHANGELOG.md

+- Test cases for Date, Time, and Datetime2 data types. [#558](https://github.com/Microsoft/mssql-jdbc/pull/558)
+
+### Fixed Issues
+- Fixed an issue where column type was not being returned correctly for spatial data types [#657](https://github.com/Microsoft/mssql-jdbc/pull/657)


"Fixed an issue where ResultSetMetadata returned incorrect columnType for Geometry and Geography data types."

cheenamalhotra · 2018-04-06T21:14:39Z

CHANGELOG.md

+
+### Fixed Issues
+- Fixed an issue where column type was not being returned correctly for spatial data types [#657](https://github.com/Microsoft/mssql-jdbc/pull/657)
+- Fixed unnecessarily creating 2 connections when multiSubnetFailover is true [#662](https://github.com/Microsoft/mssql-jdbc/pull/662)


"Fixed server side CPU Affinity problems caused by uneven connection distribution across NUMA Nodes when multiSubnetFailover is true"

cheenamalhotra · 2018-04-06T21:17:38Z

CHANGELOG.md

+### Fixed Issues
+- Fixed an issue where column type was not being returned correctly for spatial data types [#657](https://github.com/Microsoft/mssql-jdbc/pull/657)
+- Fixed unnecessarily creating 2 connections when multiSubnetFailover is true [#662](https://github.com/Microsoft/mssql-jdbc/pull/662)
+- Fixed an issue where TDS Packets weren't being completely parsed after reading rows [#664](https://github.com/Microsoft/mssql-jdbc/pull/664)


"Fixed an issue where Driver wasn't parsing TDS Packets completely to capture exceptions raised inside executed stored procedures"

cheenamalhotra · 2018-04-06T21:18:39Z

CHANGELOG.md

+- Fixed an issue where setMaxRows() would throw an exception if showplan_text is on [#666](https://github.com/Microsoft/mssql-jdbc/pull/666)
+
+### Changed
+- Removed unused imports which force users to import the ADAL4J library [#652](https://github.com/Microsoft/mssql-jdbc/pull/652)


cheenamalhotra · 2018-04-06T21:21:45Z

CHANGELOG.md

+- Fixed an issue where column type was not being returned correctly for spatial data types [#657](https://github.com/Microsoft/mssql-jdbc/pull/657)
+- Fixed unnecessarily creating 2 connections when multiSubnetFailover is true [#662](https://github.com/Microsoft/mssql-jdbc/pull/662)
+- Fixed an issue where TDS Packets weren't being completely parsed after reading rows [#664](https://github.com/Microsoft/mssql-jdbc/pull/664)
+- Fixed an issue where setMaxRows() would throw an exception if showplan_text is on [#666](https://github.com/Microsoft/mssql-jdbc/pull/666)


The issue isn't really exception from setMaxRows..

It should rather be: "Fixed an issue where driver throws exception when using setMaxRows() followed by query execution when SHOWPLAN_TEXT is ON"

Not really. Driver was throwing an exception on setMaxRows().

Let's still change it, as the internal call of setMaxRows (that throws exception) is done when client calls executeQuery(). So to the client app, its exception from query execution.

rene-ye and others added 13 commits February 2, 2018 15:46

Merge pull request #13 from v-afrafi/retryLogic

3599244

Retry logic

Added more information to error messages

a310fd2

To help debug an irreproducable/random mismatch error if it occurs in the future.

Merge branch 'dev' of https://github.com/Microsoft/mssql-jdbc into dev

d761232

Fix for the issue when using setMaxRows() with SHOWPLAN ON (microsoft…

7cd5553

…#666) * Dont throw exception for colmetadata token * Adding a comment * Update comment * Adding a warning message * remove ignoreLengthPrefixedToken

Use Socket instead of SocketChannel when multiSubnetFailover=true (mi…

0389de1

…crosoft#662)

Merge pull request #34 from Microsoft/dev

f7c801b

pull

Upped SQL Server requirement to 2017

6e49ba9

Removing Exception Test

186c798

Implement a more generic and compatible test in the future

Removed imports

cbd2d00

Used in removed test

Change in preperation for 6.5.1 preview release

188530d

Removed SNAPSHOT from POM

d1b9f9e

Added missing link

f268319

peterbae previously approved these changes Apr 6, 2018

View reviewed changes

rene-ye changed the title ~~Change in preperation for 6.5.1 preview release~~ Changes in preperation for 6.5.1 preview release Apr 6, 2018

cheenamalhotra changed the title ~~Changes in preperation for 6.5.1 preview release~~ Changes in preparation for 6.5.1 preview release Apr 6, 2018

cheenamalhotra and others added 2 commits April 6, 2018 13:44

Merge branch 'dev' into dev

53a7592

Update CHANGELOG.md

c18bb84

rene-ye dismissed peterbae’s stale review via c18bb84 April 6, 2018 20:49

Update CHANGELOG.md

fb02e25

cheenamalhotra requested changes Apr 6, 2018

View reviewed changes

rene-ye added 2 commits April 6, 2018 14:30

Update CHANGELOG.md

551773b

Update CHANGELOG.md

30927f1

cheenamalhotra approved these changes Apr 6, 2018

View reviewed changes

cheenamalhotra merged commit 03c6617 into microsoft:dev Apr 6, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Changes in preparation for 6.5.1 preview release #670

Changes in preparation for 6.5.1 preview release #670

rene-ye commented Apr 6, 2018 •

edited

Loading

codecov-io commented Apr 6, 2018 •

edited

Loading

cheenamalhotra Apr 6, 2018

cheenamalhotra Apr 6, 2018

cheenamalhotra Apr 6, 2018

cheenamalhotra Apr 6, 2018

cheenamalhotra Apr 6, 2018

ulvii Apr 6, 2018

cheenamalhotra Apr 6, 2018 •

edited

Loading

Changes in preparation for 6.5.1 preview release #670

Changes in preparation for 6.5.1 preview release #670

Conversation

rene-ye commented Apr 6, 2018 • edited Loading

codecov-io commented Apr 6, 2018 • edited Loading

Codecov Report

cheenamalhotra Apr 6, 2018

Choose a reason for hiding this comment

cheenamalhotra Apr 6, 2018

Choose a reason for hiding this comment

cheenamalhotra Apr 6, 2018

Choose a reason for hiding this comment

cheenamalhotra Apr 6, 2018

Choose a reason for hiding this comment

cheenamalhotra Apr 6, 2018

Choose a reason for hiding this comment

ulvii Apr 6, 2018

Choose a reason for hiding this comment

cheenamalhotra Apr 6, 2018 • edited Loading

Choose a reason for hiding this comment

rene-ye commented Apr 6, 2018 •

edited

Loading

codecov-io commented Apr 6, 2018 •

edited

Loading

cheenamalhotra Apr 6, 2018 •

edited

Loading