Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding error messages to resource file for spatial datatype implementation #723

Merged
merged 4 commits into from
Jun 21, 2018

Conversation

peterbae
Copy link
Contributor

added error message in resource file and changed files accordingly

@codecov-io
Copy link

codecov-io commented Jun 13, 2018

Codecov Report

Merging #723 into dev will decrease coverage by 0.09%.
The diff coverage is 41.66%.

Impacted file tree graph

@@             Coverage Diff             @@
##                dev     #723     +/-   ##
===========================================
- Coverage     48.13%   48.03%   -0.1%     
+ Complexity     2622     2618      -4     
===========================================
  Files           113      113             
  Lines         26609    26631     +22     
  Branches       4472     4472             
===========================================
- Hits          12807    12792     -15     
- Misses        11674    11717     +43     
+ Partials       2128     2122      -6
Flag Coverage Δ Complexity Δ
#JDBC42 47.52% <41.66%> (-0.04%) 2572 <4> (-1)
#JDBC43 47.91% <41.66%> (-0.08%) 2613 <4> (-1)
Impacted Files Coverage Δ Complexity Δ
...om/microsoft/sqlserver/jdbc/SQLServerResource.java 100% <ø> (ø) 4 <0> (ø) ⬇️
...in/java/com/microsoft/sqlserver/jdbc/Geometry.java 71.31% <100%> (+0.22%) 33 <2> (ø) ⬇️
...osoft/sqlserver/jdbc/SQLServerSpatialDatatype.java 86.15% <35%> (-1.29%) 257 <0> (ø)
...n/java/com/microsoft/sqlserver/jdbc/Geography.java 68.99% <50%> (-0.54%) 33 <2> (ø)
...om/microsoft/sqlserver/jdbc/ReaderInputStream.java 42.69% <0%> (-3.38%) 14% <0%> (-3%)
...n/java/com/microsoft/sqlserver/jdbc/Parameter.java 61.84% <0%> (-0.84%) 63% <0%> (ø)
...c/main/java/com/microsoft/sqlserver/jdbc/Util.java 60.91% <0%> (-0.66%) 88% <0%> (-1%)
...m/microsoft/sqlserver/jdbc/SQLServerResultSet.java 32.76% <0%> (-0.48%) 242% <0%> (-4%)
...oft/sqlserver/jdbc/SQLServerPreparedStatement.java 50.36% <0%> (-0.25%) 160% <0%> (ø)
...in/java/com/microsoft/sqlserver/jdbc/IOBuffer.java 52.99% <0%> (-0.17%) 0% <0%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61b78d7...cc86123. Read the comment docs.

@cheenamalhotra cheenamalhotra added this to the 6.5.4 milestone Jun 20, 2018
@peterbae peterbae merged commit c34e1a9 into microsoft:dev Jun 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants