Skip to content
This repository was archived by the owner on May 7, 2024. It is now read-only.

Fixing cred scan errors #253

Merged
merged 4 commits into from
Mar 4, 2021
Merged

Fixing cred scan errors #253

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
987d2f5
add placeholders as directed
udeeshagautam Mar 4, 2021
c38bb4b
missed a spot for password
udeeshagautam Mar 4, 2021
165403f
Trying a placeholder variation
udeeshagautam Mar 4, 2021
1c5ff3c
reverting the last trial change
udeeshagautam Mar 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion doc/documentation_page.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ You can set environment variables for your connection string through the followi
mssql-scripter

# set environment variable MSSQL_SCRIPTER_PASSWORD so no password input is required.
export MSSQL_SCRIPTER_PASSWORD='ABC123'
export MSSQL_SCRIPTER_PASSWORD='[PLACEHOLDER]'
mssql-scripter -S localhost -d AdventureWorks -U sa

## Generate and run scripts
Expand Down
2 changes: 1 addition & 1 deletion doc/usage_guide.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,5 +225,5 @@ You can set environment variables for your connection string through the followi
$ mssql-scripter

# set environment variable MSSQL_SCRIPTER_PASSWORD so no password input is required.
$ export MSSQL_SCRIPTER_PASSWORD='ABC123'
$ export MSSQL_SCRIPTER_PASSWORD='[PLACEHOLDER]'
$ mssql-scripter -S localhost -d AdventureWorks -U sa
10 changes: 5 additions & 5 deletions mssqlscripter/tests/test_argparser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,20 +29,20 @@ def test_connection_string_builder(self):

standard_connection = [u'-S', u'TestServer', u'-d', u'mydatabase', u'-U', 'my_username', u'-P', 'secret']
parameters = parser.parse_arguments(standard_connection)
self.assertEqual(parameters.ConnectionString, u'Server=TestServer;Database=mydatabase;User Id=my_username;Password=secret;')
self.assertEqual(parameters.ConnectionString, u'Server=TestServer;Database=mydatabase;User Id=my_username;Password=PLACEHOLDER;')

def test_connection_string_with_environment(self):
"""
Verify parser picks up connection string and password from environment variable.
"""
os.environ[parser.MSSQL_SCRIPTER_CONNECTION_STRING] = u'Server=TestServer;Database=mydatabase;User Id=my_username;Password=secret;'
os.environ[parser.MSSQL_SCRIPTER_CONNECTION_STRING] = u'Server=TestServer;Database=mydatabase;User Id=my_username;Password=PLACEHOLDER;'
parameters = parser.parse_arguments(['--append'])
self.assertEqual(parameters.ConnectionString, u'Server=TestServer;Database=mydatabase;User Id=my_username;Password=secret;')
self.assertEqual(parameters.ConnectionString, u'Server=TestServer;Database=mydatabase;User Id=my_username;Password=PLACEHOLDER;')

standard_connection = [u'-S', u'TestServer', u'-d', u'mydatabase', u'-U', 'my_username']
os.environ[parser.MSSQL_SCRIPTER_PASSWORD] = u'secret123ABC'
os.environ[parser.MSSQL_SCRIPTER_PASSWORD] = u'PLACEHOLDER'
parameters = parser.parse_arguments(standard_connection)
self.assertEqual(parameters.ConnectionString, u'Server=TestServer;Database=mydatabase;User Id=my_username;Password=secret123ABC;')
self.assertEqual(parameters.ConnectionString, u'Server=TestServer;Database=mydatabase;User Id=my_username;Password=PLACEHOLDER;')


if __name__ == u'__main__':
Expand Down