Skip to content

Commit

Permalink
SetupDataPkg: apply cpp uncrustify changes (#291)
Browse files Browse the repository at this point in the history
## Description

Updating Mu projects to apply uncrusty formatting for Cpp files, config
updated upstream in edk2 tianocore/edk2#4957 .

Config will be updated in mu_basecore
microsoft/mu_basecore#609.

For each item, place an "x" in between `[` and `]` if true. Example:
`[x]`.
_(you can also check items in the GitHub UI)_

- [ ] Impacts functionality?
- **Functionality** - Does the change ultimately impact how firmware
functions?
- Examples: Add a new library, publish a new PPI, update an algorithm,
...
- [ ] Impacts security?
- **Security** - Does the change have a direct security impact on an
application,
    flow, or firmware?
  - Examples: Crypto algorithm change, buffer overflow fix, parameter
    validation improvement, ...
- [ ] Breaking change?
- **Breaking change** - Will anyone consuming this change experience a
break
    in build or boot behavior?
- Examples: Add a new library class, move a module to a different repo,
call
    a function in a new library class in a pre-existing module, ...
- [ ] Includes tests?
  - **Tests** - Does the change include any explicit test code?
  - Examples: Unit tests, integration tests, robot tests, ...
- [ ] Includes documentation?
- **Documentation** - Does the change contain explicit documentation
additions
    outside direct code modifications (and comments)?
- Examples: Update readme file, add feature readme file, link to
documentation
    on an a separate Web page, ...

## How This Was Tested

Local CI build

## Integration Instructions

N/A
  • Loading branch information
VivianNK authored Dec 21, 2023
1 parent 55beba6 commit 02367f1
Show file tree
Hide file tree
Showing 2 changed files with 51 additions and 51 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,10 @@
#include <Library/GoogleTestLib.h>
#include <GoogleTest/Library/MockUefiRuntimeServicesTableLib.h>
extern "C" {
#include <Uefi.h>
#include <Library/BaseLib.h>
#include <Library/DebugLib.h>
#include <Library/ConfigKnobShimLib.h>
#include <Uefi.h>
#include <Library/BaseLib.h>
#include <Library/DebugLib.h>
#include <Library/ConfigKnobShimLib.h>
}

#define CONFIG_KNOB_GUID {0x52d39693, 0x4f64, 0x4ee6, {0x81, 0xde, 0x45, 0x89, 0x37, 0x72, 0x78, 0x55}}
Expand All @@ -23,27 +23,27 @@ using namespace testing;
class GetConfigKnobOverrideFromVariableStorageTest : public Test
{
protected:
StrictMock<MockUefiRuntimeServicesTableLib> RtServicesMock;
EFI_STATUS Status;
EFI_GUID ConfigKnobGuid;
CHAR16 *ConfigKnobName;
UINT64 ProfileDefaultValue;
UINTN ProfileDefaultSize;
UINT64 VariableData;
UINT64 ConfigKnobData;

// Redefining the Test class's SetUp function for test fixtures.
void
SetUp (
) override
{
ConfigKnobGuid = CONFIG_KNOB_GUID;
ConfigKnobName = (CHAR16 *)L"MyDeadBeefDelivery";
ProfileDefaultValue = 0xDEADBEEFDEADBEEF;
ProfileDefaultSize = sizeof (ProfileDefaultValue);
VariableData = 0xBEEF7777BEEF7777;
ConfigKnobData = ProfileDefaultValue;
}
StrictMock<MockUefiRuntimeServicesTableLib> RtServicesMock;
EFI_STATUS Status;
EFI_GUID ConfigKnobGuid;
CHAR16 *ConfigKnobName;
UINT64 ProfileDefaultValue;
UINTN ProfileDefaultSize;
UINT64 VariableData;
UINT64 ConfigKnobData;

// Redefining the Test class's SetUp function for test fixtures.
void
SetUp (
) override
{
ConfigKnobGuid = CONFIG_KNOB_GUID;
ConfigKnobName = (CHAR16 *)L"MyDeadBeefDelivery";
ProfileDefaultValue = 0xDEADBEEFDEADBEEF;
ProfileDefaultSize = sizeof (ProfileDefaultValue);
VariableData = 0xBEEF7777BEEF7777;
ConfigKnobData = ProfileDefaultValue;
}
};

//
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,10 @@
#include <GoogleTest/Ppi/MockReadOnlyVariable2.h>

extern "C" {
#include <Uefi.h>
#include <Library/BaseLib.h>
#include <Library/DebugLib.h>
#include <Library/ConfigKnobShimLib.h>
#include <Uefi.h>
#include <Library/BaseLib.h>
#include <Library/DebugLib.h>
#include <Library/ConfigKnobShimLib.h>
}

#define CONFIG_KNOB_GUID {0x52d39693, 0x4f64, 0x4ee6, {0x81, 0xde, 0x45, 0x89, 0x37, 0x72, 0x78, 0x55}}
Expand All @@ -26,28 +26,28 @@ using namespace testing;
class GetConfigKnobOverrideFromVariableStorageTest : public Test
{
protected:
StrictMock<MockPeiServicesLib> PeiServicesMock;
StrictMock<MockReadOnlyVariable2> PpiVariableServicesMock; // mock of EFI_PEI_READ_ONLY_VARIABLE2_PPI
EFI_STATUS Status;
EFI_GUID ConfigKnobGuid;
CHAR16 *ConfigKnobName;
UINT64 ProfileDefaultValue;
UINTN ProfileDefaultSize;
UINT64 VariableData;
UINT64 ConfigKnobData;

// Redefining the Test class's SetUp function for test fixtures.
void
SetUp (
) override
{
ConfigKnobGuid = CONFIG_KNOB_GUID;
ConfigKnobName = (CHAR16 *)L"MyDeadBeefDelivery";
ProfileDefaultValue = 0xDEADBEEFDEADBEEF;
ProfileDefaultSize = sizeof (ProfileDefaultValue);
VariableData = 0xBEEF7777BEEF7777;
ConfigKnobData = ProfileDefaultValue;
}
StrictMock<MockPeiServicesLib> PeiServicesMock;
StrictMock<MockReadOnlyVariable2> PpiVariableServicesMock; // mock of EFI_PEI_READ_ONLY_VARIABLE2_PPI
EFI_STATUS Status;
EFI_GUID ConfigKnobGuid;
CHAR16 *ConfigKnobName;
UINT64 ProfileDefaultValue;
UINTN ProfileDefaultSize;
UINT64 VariableData;
UINT64 ConfigKnobData;

// Redefining the Test class's SetUp function for test fixtures.
void
SetUp (
) override
{
ConfigKnobGuid = CONFIG_KNOB_GUID;
ConfigKnobName = (CHAR16 *)L"MyDeadBeefDelivery";
ProfileDefaultValue = 0xDEADBEEFDEADBEEF;
ProfileDefaultSize = sizeof (ProfileDefaultValue);
VariableData = 0xBEEF7777BEEF7777;
ConfigKnobData = ProfileDefaultValue;
}
};

//
Expand Down

0 comments on commit 02367f1

Please sign in to comment.