-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Untangle DFCI from configuration repo #105
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
language:python
Pull requests that update Python code
impact:breaking-change
Requires integration attention
impact:testing
Affects testing
labels
Feb 3, 2023
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #105 +/- ##
===========================================
- Coverage 45.79% 29.71% -16.08%
===========================================
Files 18 15 -3
Lines 6804 4196 -2608
===========================================
- Hits 3116 1247 -1869
+ Misses 3688 2949 -739
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
os-d
reviewed
Feb 6, 2023
SetupDataPkg/Library/SvdXmlSettingSchemaSupportLib/AllSettings.xml
Outdated
Show resolved
Hide resolved
kuqin12
force-pushed
the
dfci_overhaul
branch
from
February 6, 2023 20:50
6696433
to
f2463ca
Compare
kuqin12
commented
Feb 6, 2023
kuqin12
force-pushed
the
dfci_overhaul
branch
3 times, most recently
from
February 6, 2023 22:06
177e7bd
to
ce41f03
Compare
apop5
reviewed
Feb 6, 2023
kuqin12
force-pushed
the
dfci_overhaul
branch
from
February 7, 2023 01:48
ce41f03
to
bf65dbe
Compare
kuqin12
commented
Feb 7, 2023
SetupDataPkg/Library/ConfigVariableListLib/ConfigVariableListLib.c
Outdated
Show resolved
Hide resolved
os-d
approved these changes
Feb 7, 2023
SetupDataPkg/Library/SvdXmlSettingSchemaSupportLib/SvdXmlSettingSchemaSupport.c
Outdated
Show resolved
Hide resolved
SetupDataPkg/Library/SvdXmlSettingSchemaSupportLib/SvdXmlSettingSchemaSupportLib.inf
Outdated
Show resolved
Hide resolved
This change removes the module that is no longer needed with the new XML design. Signed-off-by: Kun Qin <kuqin@microsoft.com>
This change removes the module that is no longer needed with the new XML design. Signed-off-by: Kun Qin <kuqin@microsoft.com>
This change removes the module that is no longer needed with the new XML design. Signed-off-by: Kun Qin <kuqin@microsoft.com>
This change removes the module that is no longer needed with the new XML design. Signed-off-by: Kun Qin <kuqin@microsoft.com>
This change removes the module that is no longer needed with the new XML design. Signed-off-by: Kun Qin <kuqin@microsoft.com>
kuqin12
force-pushed
the
dfci_overhaul
branch
from
February 8, 2023 00:02
bf65dbe
to
6cfe6e3
Compare
apop5
approved these changes
Feb 8, 2023
kuqin12
force-pushed
the
dfci_overhaul
branch
from
February 8, 2023 00:49
6cfe6e3
to
756785f
Compare
This change removes the module that is no longer needed with the new XML design. Signed-off-by: Kun Qin <kuqin@microsoft.com>
This change removes the unit test module that is no longer needed with the new XML design. Signed-off-by: Kun Qin <kuqin@microsoft.com>
This change rebranded XML schema from DFCI package to this repository to support our own XML creation and parsing usage. Signed-off-by: Kun Qin <kuqin@microsoft.com>
This change removes the DFCI related logic that is no longer needed with the new XML design. The unit tests are also updated accordingly to accomodate the changes. Signed-off-by: Kun Qin <kuqin@microsoft.com>
This change removes the scripts that is no longer needed with the new XML design. Signed-off-by: Kun Qin <kuqin@microsoft.com>
kuqin12
force-pushed
the
dfci_overhaul
branch
2 times, most recently
from
February 8, 2023 01:29
a5f1525
to
2f46b3f
Compare
This change removes the YAML related logic from ConfigEditor that is no longer needed with the new XML design. Signed-off-by: Kun Qin <kuqin@microsoft.com>
This change moved git dependencies for Mu Plus and Mu Tiano to Common folder, so that checked out files are ignored as before. Signed-off-by: Kun Qin <kuqin@microsoft.com>
This change updated breaking change notes to indicate steps needed for platform integration as well as change logistics. Signed-off-by: Kun Qin <kuqin@microsoft.com>
kuqin12
force-pushed
the
dfci_overhaul
branch
from
February 8, 2023 01:34
2f46b3f
to
a880b62
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
impact:breaking-change
Requires integration attention
impact:testing
Affects testing
language:python
Pull requests that update Python code
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preface
Please ensure you have read the contribution docs prior
to submitting the pull request. In particular,
pull request guidelines.
Description
As we removes support for YAML and migrate over to XML based solutions, the DFCI based configuration path is no longer needed for such package. This package untangled DFCI dependency from configuration repository, rebranded certain library from DFCI for our own usage and updated corresponding unit tests.
Usage-wise, the only user facing change is that the USB SVD support will no longer cover targeted file search, but instead will be looking for
SetupConfUpdate.svd
for potential application.For each item, place an "x" in between
[
and]
if true. Example:[x]
.(you can also check items in the GitHub UI)
flow, or firmware?
validation improvement, ...
in build or boot behavior?
a function in a new library class in a pre-existing module, ...
outside direct code modifications (and comments)?
on an a separate Web page, ...
How This Was Tested
This change is unit tested and platform integration test is still in progress.
Integration Instructions
Platforms needs to remove non-existent libraries/headers and add
SvdXmlSettingSchemaSupportLib|SetupDataPkg/Library/SvdXmlSettingSchemaSupportLib/SvdXmlSettingSchemaSupportLib.inf
in the platform dsc file.