GoogleTest - ConfigKnobShimLib using basecore PPI mock #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
impact:non-functional
os-d
approved these changes
Jun 13, 2023
...Library/ConfigKnobShimLib/ConfigKnobShimDxeLib/GoogleTest/ConfigKnobShimDxeLibGoogleTest.cpp
Outdated
Show resolved
Hide resolved
| using namespace testing; | ||
|
|
||
| /////////////////////////////////////////////////////////////////////////////// | ||
| class GetConfigKnobOverrideFromVariableStorageTest : public Test { |
There was a problem hiding this comment.
Assuming this works, I would remove the cmocka unit tests in this same PR, no need to keep both.
...Library/ConfigKnobShimLib/ConfigKnobShimDxeLib/GoogleTest/ConfigKnobShimDxeLibGoogleTest.cpp
Outdated
Show resolved
Hide resolved
...Library/ConfigKnobShimLib/ConfigKnobShimDxeLib/GoogleTest/ConfigKnobShimDxeLibGoogleTest.inf
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## main #200 +/- ##
=======================================
Coverage 27.58% 27.58%
=======================================
Files 16 16
Lines 4520 4520
=======================================
Hits 1247 1247
Misses 3273 3273
Flags with carried forward coverage won't be shown. Click here to find out more. |
VivianNK
force-pushed
the
vnowkakeane/gtest_demo_cherry
branch
from
9efa0ff to
5d16181
Compare
…vianNK/mu_feature_config into vnowkakeane/gtest_demo_cherry
github-actions
bot
added
the
language:python
VivianNK
changed the title
VivianNK
force-pushed
the
vnowkakeane/gtest_demo_cherry
branch
from
2dfb55f to
71d1ca0
Compare
github-actions
bot
removed
the
language:python
4 tasks
VivianNK
added a commit
to VivianNK/mu_feature_config
that referenced
this pull request
Dec 19, 2023
## Description Original PR: microsoft#200 Google Tests for ConfigKnobShimDxeLib and ConfigKnobShimPeiLib ConfigKnobShimPeiLib is consuming the PPI mock from mu_basecore (microsoft/mu_basecore#579), so merging this is pending the mu_basecore PR being merged. Pipelines will fail in the meantime. - [ ] Impacts functionality? - **Functionality** - Does the change ultimately impact how firmware functions? - Examples: Add a new library, publish a new PPI, update an algorithm, ... - [ ] Impacts security? - **Security** - Does the change have a direct security impact on an application, flow, or firmware? - Examples: Crypto algorithm change, buffer overflow fix, parameter validation improvement, ... - [ ] Breaking change? - **Breaking change** - Will anyone consuming this change experience a break in build or boot behavior? - Examples: Add a new library class, move a module to a different repo, call a function in a new library class in a pre-existing module, ... - [x ] Includes tests? - **Tests** - Does the change include any explicit test code? - Examples: Unit tests, integration tests, robot tests, ... - [ ] Includes documentation? - **Documentation** - Does the change contain explicit documentation additions outside direct code modifications (and comments)? - Examples: Update readme file, add feature readme file, link to documentation on an a separate Web page, ... ## How This Was Tested Ran the tests using stuart_ci_build. ## Integration Instructions N/A
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preface
Please ensure you have read the contribution docs prior
to submitting the pull request. In particular,
pull request guidelines.
Description
Implementing GoogleTest for ConfigKnobShimLib, consuming the PPI mock from mu_basecore (microsoft/mu_basecore#579).
For each item, place an "x" in between
[and]if true. Example:[x].(you can also check items in the GitHub UI)
flow, or firmware?
validation improvement, ...
in build or boot behavior?
a function in a new library class in a pre-existing module, ...
outside direct code modifications (and comments)?
on an a separate Web page, ...
How This Was Tested
<Please describe the test(s) that were run to verify the changes.>
Integration Instructions
<Describe how these changes should be integrated. Use N/A if nothing is required.>
Add just the tests included in the demo