Reset ConIn on ConfApp entrypoint #317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
os-d
approved these changes
Feb 21, 2024
makubacki
approved these changes
Feb 21, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #317 +/- ##
=======================================
Coverage 36.10% 36.10%
=======================================
Files 31 31
Lines 6226 6226
Branches 447 447
=======================================
Hits 2248 2248
Misses 3976 3976
Partials 2 2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ProjectMuBot
referenced
this pull request
in microsoft/mu_tiano_platforms
Feb 22, 2024
Introduces 7 new commits in [Features/CONFIG](https://github.com/microsoft/mu_feature_config.git). <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/microsoft/mu_feature_config/commit/3aee7af0d5c4d29dfd9a20f3cba72882c7306e4c">3aee7a</a> Repo File Sync: synced file(s) with microsoft/mu_devops (<a href="https://github.com/microsoft/mu_feature_config/pull/311">#311</a>)</li> <li><a href="https://github.com/microsoft/mu_feature_config/commit/10bbb1950fbe041c02ea69c3ea049122216466ab">10bbb1</a> pip: bump edk2-pytool-extensions from 0.27.0 to 0.27.2 (<a href="https://github.com/microsoft/mu_feature_config/pull/313">#313</a>)</li> <li><a href="https://github.com/microsoft/mu_feature_config/commit/c60f58cb804d0cc408e9018602f768a7ed21dcc2">c60f58</a> pip: bump edk2-pytool-library from 0.20.0 to 0.21.2 (<a href="https://github.com/microsoft/mu_feature_config/pull/312">#312</a>)</li> <li><a href="https://github.com/microsoft/mu_feature_config/commit/8415b164aa707faa9e123386c8620343e2a2b7c3">8415b1</a> Repo File Sync: Improve inline documentation in CodeQL workflow (<a href="https://github.com/microsoft/mu_feature_config/pull/314">#314</a>)</li> <li><a href="https://github.com/microsoft/mu_feature_config/commit/e0c8db0c5079a90efaeb6dc61ef133c09a5487f4">e0c8db</a> remove edk2-basetools (<a href="https://github.com/microsoft/mu_feature_config/pull/315">#315</a>)</li> <li><a href="https://github.com/microsoft/mu_feature_config/commit/b673c319c770f23449164c94f7899b940dbf87cf">b673c3</a> pip: bump edk2-pytool-library from 0.21.2 to 0.21.3 (<a href="https://github.com/microsoft/mu_feature_config/pull/316">#316</a>)</li> <li><a href="https://github.com/microsoft/mu_feature_config/commit/cca9d2d80aa3f120f0573a2c498528b66bd4a653">cca9d2</a> Reset ConIn on ConfApp entrypoint (<a href="https://github.com/microsoft/mu_feature_config/pull/317">#317</a>)</li> </ul> </details> Signed-off-by: Project Mu Bot <mubot@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change added a reset call to reset the simple text input protocol installed on the gST->ConInHandle. This is needed to offset any potential dangling voltage on the serial lines after a reset, etc.
flow, or firmware?
validation improvement, ...
in build or boot behavior?
a function in a new library class in a pre-existing module, ...
outside direct code modifications (and comments)?
on an a separate Web page, ...
How This Was Tested
This was tested on a proprietary hardware platform.
Integration Instructions
N/A