Add Linux Variable Writing Script #353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
language:python
kuqin12
approved these changes
May 21, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #353 +/- ##
==========================================
- Coverage 36.29% 36.22% -0.07%
==========================================
Files 31 31
Lines 6246 6258 +12
Branches 449 449
==========================================
Hits 2267 2267
- Misses 3977 3989 +12
Partials 2 2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
apop5
approved these changes
May 21, 2024
kuqin12
reviewed
May 22, 2024
SetupDataPkg/Tools/SettingSupport/UefiVariablesSupportLinuxLib.py
Outdated
Show resolved
Hide resolved
os-d
commented
May 22, 2024
SetupDataPkg/Tools/SettingSupport/UefiVariablesSupportLinuxLib.py
Outdated
Show resolved
Hide resolved
* first error? * too many values to unpack * too many values to unpack 2 * test run * how about now? * odd? * more junk * Why does this not fail on windows? * more junk 2 * Why does this not fail on windows 2? * remove the correct part * How about now * revert some junk * Some erros * fixing is? * Not sure if this will work
* first error? * too many values to unpack * too many values to unpack 2 * test run * how about now? * odd? * more junk * Why does this not fail on windows? * more junk 2 * Why does this not fail on windows 2? * remove the correct part * How about now * revert some junk * Some erros * fixing is? * Not sure if this will work * hmm, endianness? * hardcode? * size * adding junk prints * adding junk prints 2 * update len * how about now? * revert * just try on * more prints/ * this is stupid * f it * how about now * another one * That should do * now we write * junk test * now we write * another one * one mote * one mot 2e * now? * now? * back to file ops * now * that should resolve the write part
ProjectMuBot
referenced
this pull request
in microsoft/mu_tiano_platforms
Jun 5, 2024
Introduces 9 new commits in [Features/CONFIG](https://github.com/microsoft/mu_feature_config.git). <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/microsoft/mu_feature_config/commit/22702a39b8e92af72aed9858f546fb5eff62fb4e">22702a</a> Repo File Sync: .gitattributes: Prevent line ending conversion (<a href="https://github.com/microsoft/mu_feature_config/pull/346">#346</a>)</li> <li><a href="https://github.com/microsoft/mu_feature_config/commit/2acde62130d7dde32694ea0a80351b8ab7777e3b">2acde6</a> pip: bump regex from 2024.4.28 to 2024.5.10 (<a href="https://github.com/microsoft/mu_feature_config/pull/348">#348</a>)</li> <li><a href="https://github.com/microsoft/mu_feature_config/commit/5c8ad4789f71c4c862a715156f0143b7968ef767">5c8ad4</a> pip: bump pygount from 1.6.1 to 1.8.0 (<a href="https://github.com/microsoft/mu_feature_config/pull/347">#347</a>)</li> <li><a href="https://github.com/microsoft/mu_feature_config/commit/ad7737d7c2c8a240b5ce487dbdcf6c45ec48faad">ad7737</a> pip: bump pytest from 8.2.0 to 8.2.1 (<a href="https://github.com/microsoft/mu_feature_config/pull/354">#354</a>)</li> <li><a href="https://github.com/microsoft/mu_feature_config/commit/3d2bcc44e6d542599f71e2fd76b17743841da6a9">3d2bcc</a> Add Pretty Name to Config XML (<a href="https://github.com/microsoft/mu_feature_config/pull/351">#351</a>)</li> <li><a href="https://github.com/microsoft/mu_feature_config/commit/319a618dabaccfba5f212d5f7c88d78aee41a90e">319a61</a> pip: bump regex from 2024.5.10 to 2024.5.15 (<a href="https://github.com/microsoft/mu_feature_config/pull/355">#355</a>)</li> <li><a href="https://github.com/microsoft/mu_feature_config/commit/2fffa561d0f0b17c2a51183000a7f65df63f0d21">2fffa5</a> Add Linux Variable Writing Script (<a href="https://github.com/microsoft/mu_feature_config/pull/353">#353</a>)</li> <li><a href="https://github.com/microsoft/mu_feature_config/commit/64d62365d6d6171250f8bc1d0bc03c2a6d4c219b">64d623</a> Repo File Sync: synced file(s) with microsoft/mu_devops (<a href="https://github.com/microsoft/mu_feature_config/pull/358">#358</a>)</li> <li><a href="https://github.com/microsoft/mu_feature_config/commit/c7552fe116eefe601a5dd7116ba37ab5ba937b95">c7552f</a> pip: bump edk2-pytool-extensions from 0.27.4 to 0.27.5 (<a href="https://github.com/microsoft/mu_feature_config/pull/359">#359</a>)</li> </ul> </details> Signed-off-by: Project Mu Bot <mubot@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds a Python script to write UEFI variables to and from config bins from Linux. The current support is only for Windows.
For each item, place an "x" in between
[and]if true. Example:[x].(you can also check items in the GitHub UI)
flow, or firmware?
validation improvement, ...
in build or boot behavior?
a function in a new library class in a pre-existing module, ...
outside direct code modifications (and comments)?
on an a separate Web page, ...
How This Was Tested
Tested in Ubuntu 24.04 with the QemuQ35 virtual platform using mu_feature_config as well as on physical platforms using it.
Integration Instructions
Run the same flows as for the Windows script, the scripts will automatically detect that this is run from Linux and choose the right script. It needs to be run as sudo.