Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to use edk2-pytool-library UefiVariableSupportLib. #362

Merged
merged 1 commit into from
Aug 7, 2024
Merged

Switch to use edk2-pytool-library UefiVariableSupportLib. #362

merged 1 commit into from
Aug 7, 2024

Conversation

apop5
Copy link
Contributor

@apop5 apop5 commented Jun 7, 2024 •
edited
Loading

Description

There are multiple copies of VariableSupportLib floating across repos, mostly only supporting Windows.
Functionality has been consolidated into edk2-pytool-library version 0.21.7. Support for Linux has been added.

Switch ReadUefiVarsToConfVarList.py, PyRobotRemote.py, WrapAndSetSvd.py and WriteConfVarListToUefiVars.py to use consolidated version from edk2-pytool-library.

Removed local copies of VariableSupportLib.py

For each item, place an "x" in between [ and ] if true. Example: [x].
(you can also check items in the GitHub UI)

  • Impacts functionality?
    • Functionality - Does the change ultimately impact how firmware functions?
    • Examples: Add a new library, publish a new PPI, update an algorithm, ...
  • Impacts security?
    • Security - Does the change have a direct security impact on an application,
      flow, or firmware?
    • Examples: Crypto algorithm change, buffer overflow fix, parameter
      validation improvement, ...
  • Breaking change?
    • Breaking change - Will anyone consuming this change experience a break
      in build or boot behavior?
    • Examples: Add a new library class, move a module to a different repo, call
      a function in a new library class in a pre-existing module, ...
  • Includes tests?
    • Tests - Does the change include any explicit test code?
    • Examples: Unit tests, integration tests, robot tests, ...
  • Includes documentation?
    • Documentation - Does the change contain explicit documentation additions
      outside direct code modifications (and comments)?
    • Examples: Update readme file, add feature readme file, link to documentation
      on an a separate Web page, ...

How This Was Tested

Integration Instructions

N/A

@apop5 apop5 marked this pull request as draft June 7, 2024 21:29
@github-actions github-actions bot added the language:python Pull requests that update Python code label Jun 7, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 36.24%. Comparing base (7a3ae63) to head (eac7498).

❗ Current head eac7498 differs from pull request most recent head 314c7f7

Please upload reports for the commit 314c7f7 to get more accurate results.

Files Patch % Lines
SetupDataPkg/Tools/WrapAndSetSvd.py 0.00% 2 Missing ⚠️
SetupDataPkg/Tools/ReadUefiVarsToConfVarList.py 0.00% 1 Missing ⚠️
SetupDataPkg/Tools/WriteConfVarListToUefiVars.py 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #362      +/-   ##
==========================================
+ Coverage   36.22%   36.24%   +0.02%     
==========================================
  Files          31       31              
  Lines        6258     6254       -4     
  Branches      449      449              
==========================================
  Hits         2267     2267              
+ Misses       3989     3985       -4     
  Partials        2        2
Flag Coverage Δ
Linux 27.58% <0.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@apop5 apop5 changed the title Bump edk2-pytool-library to 0.21.7. Switch functions using local Uefi… Switch to use edk2-pytool-library UefiVariableSupportLib. Jul 29, 2024
@apop5 apop5 force-pushed the personal/apop5/switchvariablesupport branch from 314c7f7 to d95467c Compare August 2, 2024 22:16
@apop5 apop5 marked this pull request as ready for review August 2, 2024 22:16
@apop5 apop5 requested a review from os-d August 3, 2024 02:20
@apop5 apop5 force-pushed the personal/apop5/switchvariablesupport branch 2 times, most recently from 8d8511b to 0753e47 Compare August 7, 2024 22:39
@apop5
Switch functions using local UefiVariableSupportLib*.py to using edk2…
bdc0ec5 
…-pytool-library versions.

Remove Local UefiVariableSupportLib instances.
Modified spellcheck.
@apop5 apop5 force-pushed the personal/apop5/switchvariablesupport branch from 0753e47 to bdc0ec5 Compare August 7, 2024 23:20
@apop5 apop5 merged commit 377d984 into microsoft:main Aug 7, 2024
12 checks passed
ProjectMuBot referenced this pull request in microsoft/mu_tiano_platforms Sep 13, 2024
@ProjectMuBot
Bumps Features/CONFIG from 2.0.13 to 3.0.0
093dc60 
Introduces 22 new commits in [Features/CONFIG](https://github.com/microsoft/mu_feature_config.git).

<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/microsoft/mu_feature_config/commit/fb0659ddf4a1376951f94965897066c3c45a1147">fb0659</a> SetupDataPkg/ConfApp: Fix incorrect type used in a GUID print (<a href="https://github.com/microsoft/mu_feature_config/pull/381">#381</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_config/commit/ab355596cfbb954f0409c8eb6064902a24c9953f">ab3555</a> pip: bump edk2-pytool-extensions from 0.27.9 to 0.27.10 (<a href="https://github.com/microsoft/mu_feature_config/pull/382">#382</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_config/commit/7eb698bda947c51147c915af5a171c7723940ccb">7eb698</a> Removing script that would create windows executable from a python file. (<a href="https://github.com/microsoft/mu_feature_config/pull/380">#380</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_config/commit/07d1b669353f00403ca11eb3ce39c61dd37ef3a4">07d1b6</a> pip: bump pytest from 8.2.2 to 8.3.1 (<a href="https://github.com/microsoft/mu_feature_config/pull/384">#384</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_config/commit/84061c7aa8e6f9e052cd6a0721f921eae0bb3e03">84061c</a> pip: bump pyopenssl from 24.1.0 to 24.2.1 (<a href="https://github.com/microsoft/mu_feature_config/pull/383">#383</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_config/commit/473977c0b06652214e6939d328896d35368e8384">473977</a> pip: bump regex from 2024.5.15 to 2024.7.24 (<a href="https://github.com/microsoft/mu_feature_config/pull/387">#387</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_config/commit/a9ead46400658dc0cedd136ce2251eeeee6fe069">a9ead4</a> pip: bump xmlschema from 3.3.1 to 3.3.2 (<a href="https://github.com/microsoft/mu_feature_config/pull/386">#386</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_config/commit/e6856ba7a4424c55089debd983ece44cd037037b">e6856b</a> pip: bump pytest from 8.3.1 to 8.3.2 (<a href="https://github.com/microsoft/mu_feature_config/pull/385">#385</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_config/commit/2c08cd5c62bd9ffe20f8fe6d41b9d56d104484bd">2c08cd</a> pip: bump edk2-pytool-library from 0.21.8 to 0.21.9 (<a href="https://github.com/microsoft/mu_feature_config/pull/388">#388</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_config/commit/c4ffcc4412785aba46f5498d79175f99c1fb4e40">c4ffcc</a> pip: bump flake8 from 7.1.0 to 7.1.1 (<a href="https://github.com/microsoft/mu_feature_config/pull/391">#391</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_config/commit/5552edcd3c09fae9d272372d5dc5f6ea4ec5d66f">5552ed</a> pip: bump antlr4-python3-runtime from 4.13.1 to 4.13.2 (<a href="https://github.com/microsoft/mu_feature_config/pull/390">#390</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_config/commit/377d9844a271eca2f050ad29411e97e30494e332">377d98</a> Switch to use edk2-pytool-library UefiVariableSupportLib. (<a href="https://github.com/microsoft/mu_feature_config/pull/362">#362</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_config/commit/bd44e7931fa86b7923678804271f464cfd7c9126">bd44e7</a> pip: bump edk2-pytool-library from 0.21.9 to 0.21.10 (<a href="https://github.com/microsoft/mu_feature_config/pull/389">#389</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_config/commit/7d4a54e701841709b317647e05c7a8ffe53c03cf">7d4a54</a> Repo File Sync: synced file(s) with microsoft/mu_devops (<a href="https://github.com/microsoft/mu_feature_config/pull/392">#392</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_config/commit/f7a1e789745eeefe9afe8b7bc4a4b12254becde5">f7a1e7</a> pip: bump edk2-pytool-extensions from 0.27.10 to 0.27.11 (<a href="https://github.com/microsoft/mu_feature_config/pull/393">#393</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_config/commit/453b5f10d2114626af063fcc028ea21e1da26450">453b5f</a> New write_csv_detailed() to dump out data in expanded format (<a href="https://github.com/microsoft/mu_feature_config/pull/365">#365</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_config/commit/837cef0c3d9551d8338945340c0fe201d8742845">837cef</a> pip: bump pefile from 2023.2.7 to 2024.8.26 (<a href="https://github.com/microsoft/mu_feature_config/pull/395">#395</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_config/commit/45e7ee76295af096bbe4b1c493580800fc36e110">45e7ee</a> Update CI branches to release/202405 (<a href="https://github.com/microsoft/mu_feature_config/pull/394">#394</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_config/commit/845fae589a8968ae43b417a2cf9b5dcaab4c0b5b">845fae</a> pip: bump edk2-pytool-extensions from 0.27.11 to 0.27.12 (<a href="https://github.com/microsoft/mu_feature_config/pull/396">#396</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_config/commit/b0593c6c47fb62bb1f6477de0d98da5e31941e55">b0593c</a> Remove DFCI Python Scripts (<a href="https://github.com/microsoft/mu_feature_config/pull/397">#397</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_config/commit/08512dfabc0fb1e9b8111e35c61b810de4c3bed4">08512d</a> pip: bump xmlschema from 3.3.2 to 3.4.0 (<a href="https://github.com/microsoft/mu_feature_config/pull/398">#398</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_config/commit/4a6d3a356f87794ce332534853434ecbc6e5d84c">4a6d3a</a> pip: bump pytest from 8.3.2 to 8.3.3 (<a href="https://github.com/microsoft/mu_feature_config/pull/399">#399</a>)</li>
</ul>
</details>

Signed-off-by: Project Mu Bot <mubot@microsoft.com>
@ProjectMuBot ProjectMuBot mentioned this pull request Sep 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kuqin12 kuqin12 kuqin12 approved these changes

@os-d os-d os-d approved these changes

Assignees
No one assigned
Labels
language:python Pull requests that update Python code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@apop5 @codecov-commenter @os-d @kuqin12