Add new features in config editor #413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit provides ability to read/write variable from SUT directly. This helps users to read/write variable conveniently.
github-actions
bot
added
language:python
kanechen66
force-pushed
the
add_new_features_config_editor
branch
3 times, most recently
from
98de4a1 to
3c7275e
Compare
BoardMiscInfo.py will be used to get the basic info from SUT
kanechen66
force-pushed
the
add_new_features_config_editor
branch
2 times, most recently
from
6dedf4c to
f6e8fc2
Compare
kanechen66
force-pushed
the
add_new_features_config_editor
branch
2 times, most recently
from
0a1ef0a to
7beb6fe
Compare
… in status canvas. Added seperators to menu to group items so commands that are linked are more clearly visible.
kanechen66
force-pushed
the
add_new_features_config_editor
branch
from
7beb6fe to
8500345
Compare
|
@apop5 |
|
hi all, |
apop5
reviewed
Nov 4, 2024
apop5
reviewed
Nov 4, 2024
apop5
approved these changes
Nov 4, 2024
os-d
approved these changes
Nov 4, 2024
1. show variable menu only in admin mode 2. show error log in status box if var is not del successfully
kanechen66
force-pushed
the
add_new_features_config_editor
branch
from
7c99ccc to
d8aba79
Compare
@microsoft-github-policy-service agree company="Microsoft" |
|
hi all |
|
It looked good in the testing of the latest. |
5 tasks
apop5
pushed a commit
that referenced
this pull request
Nov 8, 2024
## Description There is an unnecessary argument -x in the `WriteConfVarListToUefiVars.py` script in PR #413 - [x] Impacts functionality? - [ ] Impacts security? - [ ] Breaking change? - [ ] Includes tests? - [ ] Includes documentation? ## How This Was Tested python WriteConfVarListToUefiVars.py -l test.vl and it doesn't require -x arg ## Integration Instructions N/A
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this PR, we added the below new features in config editor
For details on how to complete these options and their meaning refer to CONTRIBUTING.md.
How This Was Tested
We tested on real SUT and verify each function we added.
<Describe the test(s) that were run to verify the changes.>
Integration Instructions
<Describe how these changes should be integrated. Use N/A if nothing is required.>
N/A