Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing gSchemaXmlHash in PlatformConfigDataLibNull.c #425

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

kanechen66
Copy link
Contributor

Description

Add missing gSchemaXmlHash in PlatformConfigDataLibNull.c for stuart_ci_build test

For details on how to complete these options and their meaning refer to CONTRIBUTING.md.

  • Impacts functionality?
  • Impacts security?
  • Breaking change?
  • Includes tests?
  • Includes documentation?

How This Was Tested

stuart_ci_build pipeline test pass

Integration Instructions

@github-actions github-actions bot added the impact:non-functional Does not have a functional impact label Nov 29, 2024
@kanechen66
Copy link
Contributor Author

@apop5 @os-d
Sorry that I recently found stuart_ci_build test fail due in internal pipeline and it requires this commit.
thanks.

@apop5 apop5 requested a review from os-d December 2, 2024 16:04
@apop5
Copy link
Contributor

apop5 commented Dec 2, 2024

@kanechen66

Do you know how the current CI didn't pick up this missing change?

Ideally, we would like to catch this in the PR before being able to merge.

@os-d os-d merged commit ef26461 into microsoft:main Dec 2, 2024
12 checks passed
@kanechen66
Copy link
Contributor Author

@kanechen66

Do you know how the current CI didn't pick up this missing change?

Ideally, we would like to catch this in the PR before being able to merge.

Hi Aaron,
i found it when i do stuart_ci_build on another module depends on this package.
thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact:non-functional Does not have a functional impact
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants