Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add protocol for simple access to the IPMI System Event Log #202

Merged
merged 13 commits into from
Jan 24, 2024

Conversation

cfernald
Copy link
Contributor

Description

This pull request creates a DXE module and protocol to allow simple access to the IPMI System Event Log. This protocol is intended to be used by boot loaders, diagnostics tools, and other non-system components to allow less privileged access to the SEL.

  • Impacts functionality?
  • Impacts security?
  • Breaking change?
  • Includes tests?
  • Includes documentation?

How This Was Tested

Tested on local emulated machine.

Integration Instructions

N/A

@codecov-commenter
Copy link

codecov-commenter commented Jan 13, 2024

Codecov Report

Attention: 47 lines in your changes are missing coverage. Please review.

Comparison is base (83f79a2) 26.04% compared to head (5c965a3) 25.80%.

Files Patch % Lines
IpmiFeaturePkg/IpmiSel/IpmiSel.c 0.00% 47 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #202      +/-   ##
==========================================
- Coverage   26.04%   25.80%   -0.25%     
==========================================
  Files          43       44       +1     
  Lines        3195     3248      +53     
  Branches      270      271       +1     
==========================================
+ Hits          832      838       +6     
- Misses       2357     2404      +47     
  Partials        6        6              
Flag Coverage Δ
IpmiFeaturePkg 25.80% <14.54%> (-0.25%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@apop5
Copy link
Contributor

apop5 commented Jan 13, 2024

Looks good to me

@cfernald cfernald marked this pull request as ready for review January 19, 2024 05:40
cfernald and others added 5 commits January 18, 2024 21:40
Co-authored-by: Aaron <105021049+apop5@users.noreply.github.com>
Co-authored-by: Michael Kubacki <michael.kubacki@microsoft.com>
@cfernald cfernald enabled auto-merge (squash) January 23, 2024 18:49
@cfernald cfernald merged commit 652c9dc into microsoft:main Jan 24, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants